-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Faint lines between nodes in 0.14.0rc2 #13807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The issue probably that the edges are on a half pixel, so they end up getting antialiased. But I'm not sure what the right fix is here. If there wasn't another shape there the edge should get antialiased since it's not fully on the pixel. |
I had a similar thought and added 1px to one of the boxes and saw the same behavior. I'm not sure if that's the right way to test though. |
# Objective - Fixes #13807 ## Solution - Before this pr we antialiased between 0.5 and -0.5. This pr changes things to antialias between 0.25 and -0.25. I tried slightly larger ranges, but the edge between the boxes still showed. I'm not 100% sure this is the correct solution, but from what I could find the range you use is more art than science. ## Testing - Ran rounded_borders example, the code in the linked issue, and the testing example from #12702. --- ## Changelog - reduce antialiasing in ui shader.
# Objective - Fixes #13807 ## Solution - Before this pr we antialiased between 0.5 and -0.5. This pr changes things to antialias between 0.25 and -0.25. I tried slightly larger ranges, but the edge between the boxes still showed. I'm not 100% sure this is the correct solution, but from what I could find the range you use is more art than science. ## Testing - Ran rounded_borders example, the code in the linked issue, and the testing example from #12702. --- ## Changelog - reduce antialiasing in ui shader.
Bevy version
release-0.14
, currentmain
(d659a1f7d506c5c6eba9dfe2a6e878a8c72ecef6
)bisected to #13523
Relevant system information
scale_factor
2.0
What you did
Code
What went wrong
There are faint lines between the adjacent flex nodes.
0.13.2
main
Additional information
This was reported by a user who experienced a similar issue in the wild while migrating their project to 0.14.0-rc.2.
The text was updated successfully, but these errors were encountered: