Replies: 3 comments 3 replies
-
I'd be strongly opposed to removing it, as it makes it drastically easier to validate CI locally (which I do every now and then). |
Beta Was this translation helpful? Give feedback.
-
Would cargo-xtask split the middle and offer local extensibility and structure while possibly remaining compatible with more surrounding components? Or does it share most of the same concerns? |
Beta Was this translation helpful? Give feedback.
-
I believe the problem matcher used by clippy-check is applied to all further build steps even if they don't use clippy-check. Adding a dummy actions-rs/check step at the start (eg building just the ci package, as that one should be quick to build) may be enough to get annotations for |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
By using a custom launcher (
cargo run -p ci
) forcargo fmt
andcargo clippy
, we're missing on better integrations with GitHub. For example, the clippy action https://github.com/actions-rs/clippy-check annotates issues directly in the commit (see their screenshot).Personally, I never use the
cargo run -p ci
command, and I find it harder to read in the GitHub action logs. I think it doesn't add that much value as we're just running format and clippy, and no custom actions.For reference, it was added in #1387.
I want to remove it, but would like others point of view before opening that PR.
Please vote, 👍 for "ok to remove", 👎 for "no I want to keep it"
Beta Was this translation helpful? Give feedback.
All reactions