Deprecating hashbrown stable hash reexports

Author: andristarr

crates/bevy_reflect/src/utility.rs

@@ -1,6 +1,7 @@
 //! Helpers for working with Bevy reflection.
 
 use crate::TypeInfo;
+#[allow(deprecated)]
 use bevy_utils::{FixedState, StableHashMap};
 use std::{
     any::{Any, TypeId},
@@ -195,6 +196,7 @@ impl<T: TypedProperty> NonGenericTypeCell<T> {
 /// ```
 /// [`impl_type_path`]: crate::impl_type_path
 /// [`TypePath`]: crate::TypePath
+#[allow(deprecated)]
 pub struct GenericTypeCell<T: TypedProperty>(RwLock<StableHashMap<TypeId, &'static T::Stored>>);
 
 /// See [`GenericTypeCell`].
@@ -207,6 +209,8 @@ impl<T: TypedProperty> GenericTypeCell<T> {
     pub const fn new() -> Self {
         // Use `bevy_utils::StableHashMap` over `bevy_utils::HashMap`
         // because `BuildHasherDefault` is unfortunately not const.
+
+        #[allow(deprecated)]
         Self(RwLock::new(StableHashMap::with_hasher(FixedState)))
     }
 

crates/bevy_utils/src/lib.rs

@@ -96,6 +96,9 @@ pub type HashMap<K, V> = hashbrown::HashMap<K, V, BuildHasherDefault<AHasher>>;
 /// of insertions and deletions and not a random source.
 ///
 /// aHash is designed for performance and is NOT cryptographically secure.
+#[deprecated(
+    note = "Will be required to use the hash library of your choice. Alias for: hashbrown::HashMap<K, V, FixedState>"
+)]
 pub type StableHashMap<K, V> = hashbrown::HashMap<K, V, FixedState>;
 
 /// A [`HashSet`][hashbrown::HashSet] implementing aHash, a high
@@ -111,6 +114,9 @@ pub type HashSet<K> = hashbrown::HashSet<K, BuildHasherDefault<AHasher>>;
 /// of insertions and deletions and not a random source.
 ///
 /// aHash is designed for performance and is NOT cryptographically secure.
+#[deprecated(
+    note = "Will be required to use the hash library of your choice. Alias for: hashbrown::HashMap<K, V, FixedState>"
+)]
 pub type StableHashSet<K> = hashbrown::HashSet<K, FixedState>;
 
 /// A pre-hashed value of a specific type. Pre-hashing enables memoization of hashes that are expensive to compute.