Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with newer moz-sql-parser #15

Open
epol opened this issue Jan 22, 2021 · 0 comments
Open

Not working with newer moz-sql-parser #15

epol opened this issue Jan 22, 2021 · 0 comments

Comments

@epol
Copy link

epol commented Jan 22, 2021

When I install newer versions of moz-sql-parser queries aren't parsed and the following error is returned:

Invalid URL, must be a docs.google.com URL!

Digging into the problem I found that moz_sql_parser.parse used in extract_url changed in commit 3557475 and so in all releases after 4.10.21011.

The new version escapes the dots in the URL, so instead of https://docs.google.com/spreadsheets/d/1_rN3lm0R_bU3NemO0s9pbFkY5LQPcuy1pscv8ZXPtg8/ we get back https://docs\\.google\\.com/spreadsheets/d/1_rN3lm0R_bU3NemO0s9pbFkY5LQPcuy1pscv8ZXPtg8/

For the moment I fixed it installing moz-sql-parser==4.9.21002, do you think this issue should be solved in this project or in the moz-sql-parser code?

Issue #14 may be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant