-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to pass the client
object
#301
Comments
This can be instead of #331 Example for vllm offline: https://github.com/bespokelabsai/curator/blob/main/src/bespokelabs/curator/request_processor/offline/vllm_offline_request_processor.py#L45C1-L54C10 This way we automatically support all current and future configurations of the backend and don't have to manage it ourselves |
Current params that would fall into this: curator/src/bespokelabs/curator/llm/llm.py Lines 45 to 63 in 07cff6f
litellm / openai / anthropic litellm vllm params that don't (we manage them ourselves) Actually thinking about this further, it is still messy and this doesn't entirely solve the issue |
See https://x.com/kgourg/status/1885396492162121797?s=46 for an example of when this is useful
|
It may be a good idea to let the user specify the client. That way the user can fully configure the client however they want. This also might simplify the interface so we don't have to add things like base_url (as mentioned in #238) or full retry behavior (related to #279, by passing an httpx object).
Similar to how instruct has from_gemini from_anthropic, from_litellm etc. and takes in a client object and returns a standardized client object.
https://github.com/instructor-ai/instructor/blob/main/instructor/client_anthropic.py
We can do this for both online and batch (and offline via vllm object based on #298)
The text was updated successfully, but these errors were encountered: