[bug]: Claims can be incorrectly identified as supported

[CalebCourier]

When filtering out supported claims, this line assumes that concurrent.futures.as_completed() maintains order, which it does not, since it is zipping the claims as originally ordered with the future results as they are returned.

This means that a claim can be incorrectly identified as supported if subsequent calls made in _inference_remote return out of order (i.e. one request takes longer than another made after it).

See contrived code sample below for a simplified example:

import concurrent.futures
import time

def task(n):
    time.sleep(n)
    return n

claims = [3, 1, 2]

with concurrent.futures.ThreadPoolExecutor() as executor:
    futures = [executor.submit(task, claim) for claim in claims]
    is_supported = [future.result() for future in concurrent.futures.as_completed(futures)]


supported_claims = [
    (f"claim: {c}", f"is_supported: {s}")
    for c, s in zip(claims, is_supported)
]

print(supported_claims)

One solution would be to return a composite response from _inference_remote that includes both the original claim and the FactcheckCreateResponse for that claim.