Skip to content

Commit 4a95c44

Browse files
authored
fix: avoid null ptr of timeouts (#233)
* fix: avoid null ptr of timeouts * refactor
1 parent 5c0a6a7 commit 4a95c44

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

controllers/resources/bentorequest_controller.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1874,10 +1874,12 @@ func (r *BentoRequestReconciler) generateModelSeederJob(ctx context.Context, opt
18741874
},
18751875
},
18761876
},
1877-
Template: *podTemplateSpec,
1878-
ActiveDeadlineSeconds: ptr.To(int64(opt.BentoRequest.Spec.ImageBuildTimeout.Seconds())),
1877+
Template: *podTemplateSpec,
18791878
},
18801879
}
1880+
if opt.BentoRequest.Spec.ImageBuildTimeout != nil {
1881+
job.Spec.ActiveDeadlineSeconds = ptr.To(int64(opt.BentoRequest.Spec.ImageBuildTimeout.Seconds()))
1882+
}
18811883
err = ctrl.SetControllerReference(opt.BentoRequest, job, r.Scheme)
18821884
if err != nil {
18831885
err = errors.Wrapf(err, "set controller reference for job %s", job.Name)
@@ -2295,10 +2297,12 @@ func (r *BentoRequestReconciler) generateImageBuilderJob(ctx context.Context, op
22952297
},
22962298
},
22972299
},
2298-
Template: *podTemplateSpec,
2299-
ActiveDeadlineSeconds: ptr.To(int64(opt.BentoRequest.Spec.ImageBuildTimeout.Seconds())),
2300+
Template: *podTemplateSpec,
23002301
},
23012302
}
2303+
if opt.BentoRequest.Spec.ImageBuildTimeout != nil {
2304+
job.Spec.ActiveDeadlineSeconds = ptr.To(int64(opt.BentoRequest.Spec.ImageBuildTimeout.Seconds()))
2305+
}
23022306
err = ctrl.SetControllerReference(opt.BentoRequest, job, r.Scheme)
23032307
if err != nil {
23042308
err = errors.Wrapf(err, "set controller reference for job %s", job.Name)

0 commit comments

Comments
 (0)