-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github and .rst files #29
Comments
Hi @ardalis :) Thanks for the report. Feel free to pull-request some changes, I'll be glad to review them ;) So Github now renders Can Github render Sphinx-specific directives such as Also, is there a way to have an URL to highlight a specific line in a .rst file? Such as https://github.com/benoitbryon/documentation-style-guide-sphinx/blob/master/docs/style-guide.txt#L40? It seems https://github.com/ardalis/Docs/blob/master/docs/github-test.rst#L40 does not highlight line 40. My personal taste is: Github's primary purpose is to share (raw) code, not to transform it for rendering. Whereas Github's pages or ReadTheDocs are made to publish HTML rendered out of reStructuredText. That's why I'm not a big fan of automatic rst2html rendering at Github. But I agree that's my very personal taste, and I understand arguments in favor of For having discussed quite a lot about So, I would say it is a matter of personal taste, and yes the style guide may be updated that way. Quite a long time since I updated the style guide... I think |
Tagged as "bug" because there is something wrong in the documentation. |
Some more thoughts on using .rst or .txt:
|
In the style guide, it says:
Some programs parse
.rst
withrst2html
_, which cannot interpret someSphinx's directives such as
code-block
. So readers using such programsactually lose some content.
As an example, well known
Github
_ platform uses rst2htmlto render
.rst
files in its repository browser. Not only you losecontent, you also lose features like links to lines.
This doesn't appear to be the case (any longer). I uploaded a test here:
https://github.com/ardalis/Docs/blob/master/docs/github-test.rst
And it renders just fine (images are broken, but that's because I didn't copy them - code blocks render just fine, and no content is lost). When editing the file, it opens in a plain text editor, showing all RST markup, so again there doesn't appear to be any risk of loss of content when using .rst extension files and Github.
Can you comment and/or update the style guide?
Thanks!
Steve
The text was updated successfully, but these errors were encountered: