-
Notifications
You must be signed in to change notification settings - Fork 181
Open
Description
Problem
PR #330 added package name disambiguation for Go benchmarks with duplicate names across packages. However, some users (e.g., gofiber/fiber) already applied workarounds by manually including the package name in their benchmark names.
With the current implementation, these workarounds would result in duplicate package names:
BenchmarkFoo_middleware_cache→BenchmarkFoo_middleware_cache (github.com/gofiber/fiber/v3/middleware/cache)
Proposed Solution
Before adding the package suffix, check if the benchmark name already contains a reference to the package (full path, normalized path, or partial suffix).
Known Workaround Pattern (gofiber/fiber)
# Strip module prefix, replace / with _, append with _
BenchmarkAppendMsgitem → BenchmarkAppendMsgitem_middleware_cache
Related
- Fixes regression from fix: include package name for duplicate bench names [#264] #330
- Original issue: Golang Benchmarks don't take Package Name into consideration #264
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
In Progress