Automatic-Module-Name: org.jgroups gone in 5.4.0.Final

[eitan-rosenberg]

The MANIFEST.MF in jgroups-5.3.13.Final.jar use to have:
Automatic-Module-Name: org.jgroups
Now in jgroups-5.4.0.Final.jar it is gone.
Can it be put back ?
I think it can be done using maven-jar-plugin

[belaban]

How? Please create a JIRA with instructions (or a PR)...

[eitan-rosenberg]

I am not this kind of expert...

Usually use Eclipse to do this.

I read about it here:
https://maven.apache.org/plugins/maven-jar-plugin/examples/manifest-customization.html

So:
You already use "maven-jar-plugin" in your pom.xml

I did a small test and add manifest Entries

		<plugin>
			<groupId>org.apache.maven.plugins</groupId>
			<artifactId>maven-jar-plugin</artifactId>
			<configuration>
				<archive>
					<manifest>
						<addDefaultEntries>true</addDefaultEntries>
						<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
						<addBuildEnvironmentEntries>true</addBuildEnvironmentEntries>
						<!--addClasspath>true</addClasspath -->
						<!-- classpathPrefix>libs/</classpathPrefix -->
						<mainClass>org.jgroups.Version</mainClass>
					</manifest>
					<manifestEntries>
						<Automatic-Module-Name>org.jgroups</Automatic-Module-Name>
					</manifestEntries>
				</archive>
			</configuration>
		</plugin>

The result of "mvn package"

I hope that you find this helpful.

[eitan-rosenberg]

Found this
#688

[belaban]

I don't see Automatic-module-name in pom.xml anymore, do I need to re-add it?

[eitan-rosenberg]

Sure
You did that 2 years ago, see here #688
I wonder what happens between 5.3.13 and 5.4.0
This is not urgent

[eitan-rosenberg]

Thanks for 5.4.1.Final
org.jgroups is back in town :-)
Have a nice weekend and merry Christmas.

[belaban]

Thanks, same to you!