Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more info #1

Open
pedrofracassi opened this issue Feb 1, 2018 · 2 comments
Open

Expose more info #1

pedrofracassi opened this issue Feb 1, 2018 · 2 comments

Comments

@pedrofracassi
Copy link

pedrofracassi commented Feb 1, 2018 •
edited
Loading

It would be nice to have some more information on the meme object, like url and image

(btw, thanks for the API, I've been looking for one for a long time. Implementing it right now on my discord bot)
@pedrofracassi pedrofracassi changed the title Meme URL Expose more info Feb 1, 2018
@pedrofracassi
Copy link
Author

#2 should get is working, but probably has bugs. I'm pretty sure that a meme without an image would break it.

@pedrofracassi pedrofracassi mentioned this issue Feb 1, 2018
Closed
@ArcticZeroo
Copy link
Member

should get it working, but probably has bugs

Did you not test your PR? You need to test it before we can reasonably accept it. And it can't just fail if there is no image, instead the image property should be null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArcticZeroo @pedrofracassi