Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change coveralls from comment to status #159

Closed
nstarman opened this issue Jun 8, 2024 · 6 comments
Closed

Change coveralls from comment to status #159

nstarman opened this issue Jun 8, 2024 · 6 comments

Comments

@nstarman
Copy link
Contributor

nstarman commented Jun 8, 2024

There's not much info in the comment that isn't in the status check. The old comments don't get removed after a new commit.
Status checks can be made required to merge a PR.
See https://docs.coveralls.io/app-notifications

@wesselb
Copy link
Member

wesselb commented Jun 11, 2024

Ah, this would be really nice! I checked, but unfortunately I don't seem to have access to the settings page of the Plum Coveralls page since Plum moved to @beartype.

@leycec, I noticed that Coveralls access to the @beartype organisation is pending:

image

Would you be willing to approve that?

@leycec
Copy link
Member

leycec commented Jun 12, 2024

Gah! So sorry about that, everybody. Everything shall immediately be permitted. And... actually, I'm lost. I couldn't figure out how to do anything. Instead, I just enabled the Discussions tab for Plum and invited everybody to shower @wesselb with copious praise and fawning affection. This surely makes up for my lack of action on this probably more significant issue.

@leycec
Copy link
Member

leycec commented Jun 12, 2024

Storytime. I fell down the GitHub Settings UX labyrinth and couldn't get out. I almost gave up. My stamina was depleted. Then I valiantly performed a random walk across the heterogenous landscape of non-Euclidean madness that is the GitHub Settings UX. Finally, a shining beacon of sanity shown dimly through the haze of my pounding migraine: under "OAuth application policy," a web dev phrase that's basically meaningless to me, I found something! I found a button. I pushed a button. Sunlight filtered through. A single solitary plum fell off a nearby tree and rolled into the dim miasma of the labyrinth.

With tears in my glaucoma-addled eyes, I ate that plum. Now, so can you.

English Translation: I approved Coveralls access to the @beartype organization. 💪

@wesselb
Copy link
Member

wesselb commented Jun 13, 2024

@leycec Ahh, thank you for getting to the bottom of this so quickly. :) That's super helpful! I can confirm that I have access now. 🎉

@nstarman Unfortunately, I'm having some trouble getting Coveralls to do the check. I've configured the repo in this way:

image

I then deleted some tests in a test PR, but, no matter how I configure the settings, I can't seem to get the status check to fail: it just always passes.

Any idea what could be going on?

@nstarman
Copy link
Contributor Author

Hm. I don't use coveralls myself (all my repos use codecov) so I'm not familiar with the settings. Could it be that it needs the "SEND PATCH STATUS UPDATES?"

@wesselb
Copy link
Member

wesselb commented Jun 14, 2024

@nstarman I believe this now works! Hurray.

@wesselb wesselb closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants