Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Beneficiary from UserOp - AA90 & AA91 #42

Open
kanthgithub opened this issue Jan 16, 2024 · 3 comments
Open

Get Beneficiary from UserOp - AA90 & AA91 #42

kanthgithub opened this issue Jan 16, 2024 · 3 comments

Comments

@kanthgithub
Copy link
Contributor

kanthgithub commented Jan 16, 2024

Background

AA-90: rervert error when handleOps has beneficiary Address as Zero Address
AA-91: failure to Compensate the caller's beneficiary address with the collected fees of all UserOperations.

in Case-1 for AA-90 beneficiary address can be presumed as zero
but for AA-91 we need to extract beneficiary address to which collected fees is to be sent (and failed in this scenario)

Question

  1. How to get beneficiary when we have UserOp?

we need to enhance decodeUserOp functiob to get the beneficiary address and populate in the UserOps Object

@kanthgithub
Copy link
Contributor Author

Added beneficiary property to the userOp Struct
as all handleOps function call would definitely have beneficiary and 0th param in params passed to decoder is an userOp and it is expected to have beneficiary

change is pushed in to the commit:
50a828e

@tomarsachin2271

@kanthgithub
Copy link
Contributor Author

will add these to current working PR itself (#40)

@kanthgithub
Copy link
Contributor Author

@tomarsachin2271 added AA90 & AA91 Decoders.
for AA91 which happens when the entrypoint fails to compensate the beneficiary with collected fees
but error message doesn't include the amount or collected fees

added an issue in eth-infinitism repo, to propose if the error message can be encoded with amount or collected fees`
eth-infinitism/account-abstraction#409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant