Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how readings tool Tone customization works #71

Open
Nokel81 opened this issue Oct 29, 2023 · 3 comments
Open

Document how readings tool Tone customization works #71

Nokel81 opened this issue Oct 29, 2023 · 3 comments

Comments

@Nokel81
Copy link

Nokel81 commented Oct 29, 2023

The readings tool is amazing but it seems like the GABC modification inputs are a bit of a black art. I tried looking through the code in readings.js but I couldn't easily find the implementation of their parser, not even an eval call.

Thanks

@Nokel81
Copy link
Author

Nokel81 commented Oct 29, 2023

Also, it would be useful if the readings tool had a way to specify what to do at commas in the text, not just semi colons, colons, question marks, and periods

@bbloomf
Copy link
Owner

bbloomf commented Oct 31, 2023

It is in psalmtone.js that these things happen.

toneList = toneList.eval();
calls eval() after setting a global variable t

The eval was only set up to handle a ? : operator and you can see from that line, that it is given information about the last three syllables in reverse order.

@MRoth1910
Copy link
Contributor

MRoth1910 commented Feb 28, 2024

Yeah, I don't understand this at all, because I would prefer the standard endings for monosyllables and Hebrew words. I have never ever seen the ending for those used in Latin, and I cannot make heads or tails of what is here. A check box would be helpful. (For context, I'm currently working on setting texts to the prophecy tone.) The flex is requred, except in shorter sentences, but because not all sentences have colons, sometimes the flex is omitted, sometimes the sentence is short but, because the colon is used for dialogue it is inserted, and really, this is a problem, insofar as the rules are contradictory. The flex is repeated if it makes sense, but the flex before introducing dialogue does not make sense! It is a dependent clause. (The St Athanasius Chant book of epistles and gospels does this too.)

The ending for the readings preceding the Canticle of Moses and that of the Three Young Men would also be helpful, but again, the documentation is fairly complex…

Even just a note that this is a problem would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants