Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] AMD Support #31

Closed
Integralist opened this issue Sep 29, 2013 · 2 comments
Closed

[PROPOSAL] AMD Support #31

Integralist opened this issue Sep 29, 2013 · 2 comments

Comments

@Integralist
Copy link
Contributor

BBC's original implementation of Imager (known as Image Enhancer) was wrapped up as an AMD module so it could be loaded into other scripts using an AMD compatible loader script such as RequireJS or Curl.

Before we can re-introduce the new and improved Imager back into the BBC code base we'd need to ensure it is AMD compatible (currently it's not, it creates a global Imager property instead).

/cc @oncletom

@thom4parisot
Copy link
Contributor

I guess it could be used to leverage the custom build, by making an imager/events module for example (cf. #25 and #30), and imager/strategy/replacer etc.

@thom4parisot
Copy link
Contributor

We can close it as it's now done in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants