Only apply tsetse checks to internal repository

Verify that tsetse is not run on external targets

Closes #293

PiperOrigin-RevId: 215772284

Author: gregmagolan

.bazelci/presubmit.yml

@@ -6,6 +6,7 @@ platforms:
     - "@nodejs//:yarn"
     build_targets:
     - "..."
+    - "@disable_tsetse_for_external_test//..."
     test_flags:
     # TODO(gregmagolan): shared libs needed by chrome & firefox not available on ubuntu1404
     - "--test_tag_filters=-browser:chromium-local,-browser:firefox-local"
@@ -17,6 +18,7 @@ platforms:
     - "@nodejs//:yarn"
     build_targets:
     - "..."
+    - "@disable_tsetse_for_external_test//..."
     test_flags:
     # TODO(gregmagolan): shared libs needed by chrome & firefox not available on ubuntu1604
     - "--test_tag_filters=-browser:chromium-local,-browser:firefox-local"
@@ -28,6 +30,7 @@ platforms:
     - "@nodejs//:yarn"
     build_targets:
     - "..."
+    - "@disable_tsetse_for_external_test//..."
     test_flags:
     # TODO(gregmagolan): chrome & firefox unknown breakage on macos target here; does work locally on mac
     - "--test_tag_filters=-browser:chromium-local,-browser:firefox-local"
@@ -39,5 +42,6 @@ platforms:
     - "@nodejs//:yarn"
     build_targets:
     - "..."
+    - "@disable_tsetse_for_external_test//..."
     test_targets:
     - "..."

.circleci/config.yml

@@ -56,6 +56,7 @@ jobs:
       - run: bazel info release
       - run: bazel build ...
       - run: bazel test ...
+      - run: bazel build @disable_tsetse_for_external_test//...
 
   # This job tests the same stuff, but without the .bazelrc file.
   # It disables worker mode, for example.
@@ -77,6 +78,7 @@ jobs:
       # is required to keep Bazel from exhausting the memory.
       - run: bazel --bazelrc=/dev/null --host_jvm_args=-Xmx3g build ... --local_resources=2560,1.0,1.0
       - run: bazel --bazelrc=/dev/null --host_jvm_args=-Xmx3g test ... --local_resources=2560,1.0,1.0
+      - run: bazel --bazelrc=/dev/null --host_jvm_args=-Xmx3g build @disable_tsetse_for_external_test//... --local_resources=2560,1.0,1.0
 
       - save_cache:
           key: *cache_key

WORKSPACE

@@ -199,3 +199,8 @@ local_repository(
   name = "package_typescript_karma_e2e",
   path = "internal/e2e/package_typescript_karma",
 )
+
+local_repository(
+  name = "disable_tsetse_for_external_test",
+  path = "internal/e2e/disable_tsetse_for_external",
+)

internal/build_defs.bzl

@@ -199,6 +199,22 @@ def tsc_wrapped_tsconfig(
     if jsx_factory:
         config["compilerOptions"]["jsxFactory"] = jsx_factory
 
+    tsetse_disabled_rules = []
+
+    # Matches section in javascript/typescript/tsconfig.bzl
+    # TODO(alexeagle): make them share code
+    if ctx.label.workspace_root.startswith("external/"):
+        # Violated by rxjs
+        tsetse_disabled_rules += ["ban-promise-as-condition"]
+
+        # For local testing
+        tsetse_disabled_rules += ["check-return-value"]
+
+    config["compilerOptions"]["plugins"] = [{
+        "name": "@bazel/tsetse",
+        "disabledRules": tsetse_disabled_rules,
+    }]
+
     return config
 
 # ************ #

internal/e2e/disable_tsetse_for_external/BUILD.bazel

@@ -0,0 +1,23 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+package(default_visibility = ["//visibility:public"])
+
+load("@build_bazel_rules_typescript//internal:defaults.bzl", "ts_library")
+
+ts_library(
+    name = "main",
+    srcs = glob(["*.ts"]),
+    deps = ["@npm//@types"],
+)

internal/e2e/disable_tsetse_for_external/WORKSPACE

@@ -0,0 +1,15 @@
+# Copyright 2017 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+workspace(name = "disable_tsetse_for_external_test")

internal/e2e/disable_tsetse_for_external/main.ts

@@ -0,0 +1,19 @@
+export {};
+
+// string.trim() result is unused
+let stringUnused;
+stringUnused = 'hello';
+stringUnused.trim();
+const stringLiteralUnused = 'hello';
+stringLiteralUnused.trim();
+
+// Array.concat() result is unused.
+const arrayOfStringsUnused = ['hello'];
+arrayOfStringsUnused.concat(arrayOfStringsUnused);
+
+// Object.create() result is unused
+const objectUnused = {};
+Object.create(objectUnused);
+
+// string.replace() with a substring
+stringUnused.replace('o', 'O');