Call gatherDiagnostics to perform syntax/semantic/type checks

This was accidentally removed in recent refactoring 1b33eba
which caused TS compilations to incorrectly succeed when the code contains errors.

Restore missing tests which would have caught the regression; these were also accidentally disabled when Bazel BUILD files were refactored.

PiperOrigin-RevId: 224869541

Author: alexeagle

internal/BUILD.bazel

@@ -17,11 +17,11 @@
 package(default_visibility = ["//visibility:public"])
 
 exports_files([
-    "tsconfig.json",
     # Exported to be consumed for generating skydoc.
     "build_defs.bzl",
     "ts_config.bzl",
     "ts_repositories.bzl",
+    "tsetse/tsconfig.json",
 ])
 
 load("//internal:defaults.bzl", "ts_library")
@@ -98,6 +98,7 @@ ts_library(
         ":tsc_wrapped",
         "@npm//@types/jasmine",
         "@npm//@types/node",
+        "@npm//tsickle",
         "@npm//typescript",
     ],
 )

internal/tsc_wrapped/tsc_wrapped.ts

@@ -205,6 +205,30 @@ function runFromOptions(
           compilerHost.inputFiles, options, compilerHost, oldProgram));
   cache.putProgram(bazelOpts.target, program);
 
+  if (!bazelOpts.isJsTranspilation) {
+    // If there are any TypeScript type errors abort now, so the error
+    // messages refer to the original source.  After any subsequent passes
+    // (decorator downleveling or tsickle) we do not type check.
+    let diagnostics =
+        gatherDiagnostics(options, bazelOpts, program, disabledTsetseRules);
+    if (!expectDiagnosticsWhitelist.length ||
+        expectDiagnosticsWhitelist.some(p => bazelOpts.target.startsWith(p))) {
+      diagnostics = bazelDiagnostics.filterExpected(
+          bazelOpts, diagnostics, bazelDiagnostics.uglyFormat);
+    } else if (bazelOpts.expectedDiagnostics.length > 0) {
+      console.error(
+          `Only targets under ${
+              expectDiagnosticsWhitelist.join(', ')} can use ` +
+              'expected_diagnostics, but got',
+          bazelOpts.target);
+    }
+
+    if (diagnostics.length > 0) {
+      console.error(bazelDiagnostics.format(bazelOpts.target, diagnostics));
+      debug('compilation failed at', new Error().stack!);
+      return false;
+    }
+  }
 
   const compilationTargets = program.getSourceFiles().filter(
       fileName => isCompilationTarget(bazelOpts, fileName));

internal/tsetse/tests/ban_expect_truthy_promise/BUILD

@@ -29,7 +29,7 @@ ts_library(
 ts_library(
     name = "positives",
     testonly = 1,
-    tsconfig = "//internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     srcs = [
         "positives.ts",
     ],
@@ -50,7 +50,7 @@ ts_library(
 ts_library(
     name = "negatives",
     testonly = 1,
-    tsconfig = "//internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     srcs = [
         "negatives.ts",
     ],

internal/tsetse/tests/ban_promise_as_condition/BUILD

@@ -18,15 +18,10 @@ load("//internal:defaults.bzl", "ts_library")
 
 error_message = "error TS21226: Found a thenable.*"
 
-ts_library(
-    name = "jasmine",
-    testonly = 1,
-)
-
 ts_library(
     name = "positives",
     testonly = 1,
-    tsconfig = "//internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     srcs = [
         "positives.ts",
     ],
@@ -49,7 +44,7 @@ ts_library(
 ts_library(
     name = "negatives",
     testonly = 1,
-    tsconfig = "//internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     srcs = ["negatives.ts"],
     deps = [
     ],

internal/tsetse/tests/check_return_value/BUILD

@@ -23,7 +23,7 @@ ts_library(
     name = "no_expected_diagnostics_test",
     testonly = 1,
     srcs = ["no_expected_diagnostics.ts"],
-    tsconfig = "//third_party/bazel_rules/rules_typescript/internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
 )
 
 ts_library(
@@ -37,14 +37,14 @@ ts_library(
         "\(16,1\).*" + error_message,
         "\(19,1\).*" + error_message,
     ],
-    tsconfig = "//third_party/bazel_rules/rules_typescript/internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
 )
 
 ts_library(
     name = "user_defined_check_return_value",
     testonly = 1,
     srcs = ["user_defined_check_return_value.ts"],
-    tsconfig = "//third_party/bazel_rules/rules_typescript/internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
 )
 
 ts_library(
@@ -57,9 +57,8 @@ ts_library(
         "\(7,1\).*" + error_message,
         "\(9,1\).*" + error_message,
         "\(15,1\).*" + error_message,
-        "\(16,1\).*" + error_message,
     ],
-    tsconfig = "//third_party/bazel_rules/rules_typescript/internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     deps = [
         ":user_defined_check_return_value",
         "@npm//@types/jasmine",

internal/tsetse/tests/must_use_promises/BUILD

@@ -25,13 +25,14 @@ ts_library(
     srcs = [
         "positives.ts",
     ],
-    tsconfig = "//third_party/bazel_rules/rules_typescript/internal/tsetse:tsconfig.json",
+    tsconfig = "//internal:tsetse/tsconfig.json",
     expected_diagnostics = [
         "\(29,3\)" + error_message,
         "\(30,3\)" + error_message,
         "\(31,3\)" + error_message,
         "\(32,3\)" + error_message,
         "\(34,3\)" + error_message,
     ],
-    deps = ["//third_party/javascript/node_modules/typescript:es2015.promise"],
+    deps = [
+    ],
 )

internal/tsetse/tsconfig.json

@@ -2,7 +2,6 @@
   "compilerOptions": {
     "strict": true,
     "types": [
-      "node"
     ],
     "lib": [
       "dom",