Skip to content

Commit 47cd850

Browse files
Merge pull request #242 from keith:ks/update-protobuf
PiperOrigin-RevId: 250495171
2 parents 5933dae + d281e47 commit 47cd850

File tree

4 files changed

+19
-22
lines changed

4 files changed

+19
-22
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,13 @@ load(
7070
)
7171

7272
apple_support_dependencies()
73+
74+
load(
75+
"@com_google_protobuf//:protobuf_deps.bzl",
76+
"protobuf_deps",
77+
)
78+
79+
protobuf_deps()
7380
```
7481

7582
The `swift_rules_dependencies` macro creates a toolchain appropriate for your

WORKSPACE

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,10 @@ load(
1313
)
1414

1515
apple_support_dependencies()
16+
17+
load(
18+
"@com_google_protobuf//:protobuf_deps.bzl",
19+
"protobuf_deps",
20+
)
21+
22+
protobuf_deps()

swift/repositories.bzl

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -88,30 +88,13 @@ def swift_rules_dependencies():
8888
_maybe(
8989
http_archive,
9090
name = "com_google_protobuf",
91-
# v3.7.1, latest as of 2019-04-03
92-
urls = ["https://github.com/protocolbuffers/protobuf/archive/v3.7.1.zip"],
93-
sha256 = "f976a4cd3f1699b6d20c1e944ca1de6754777918320c719742e1674fcf247b7e",
94-
strip_prefix = "protobuf-3.7.1",
91+
# v3.8.0, latest as of 2019-05-28
92+
urls = ["https://github.com/protocolbuffers/protobuf/archive/v3.8.0.zip"],
93+
sha256 = "1e622ce4b84b88b6d2cdf1db38d1a634fe2392d74f0b7b74ff98f3a51838ee53",
94+
strip_prefix = "protobuf-3.8.0",
9595
type = "zip",
9696
)
9797

98-
# TODO(https://github.com/protocolbuffers/protobuf/issues/5918):
99-
# Remove this when protobuf releases protobuf_deps.bzl and instruct users to call
100-
# `protobuf_deps()` instead.
101-
if not native.existing_rule("net_zlib"):
102-
http_archive(
103-
name = "net_zlib",
104-
build_file = "@com_google_protobuf//examples:third_party/zlib.BUILD",
105-
sha256 = "c3e5e9fdd5004dcb542feda5ee4f0ff0744628baf8ed2dd5d66f8ca1197cb1a1",
106-
strip_prefix = "zlib-1.2.11",
107-
urls = ["https://zlib.net/zlib-1.2.11.tar.gz"],
108-
)
109-
110-
native.bind(
111-
name = "zlib",
112-
actual = "@net_zlib//:zlib",
113-
)
114-
11598
_maybe(
11699
swift_autoconfiguration,
117100
name = "build_bazel_rules_swift_local_config",

third_party/com_github_grpc_grpc_swift/BUILD.overlay

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ cc_library(
5252
tags = ["swift_module=CgRPC"],
5353
deps = [
5454
":BoringSSL",
55-
"//external:zlib",
55+
"@zlib//:zlib",
5656
],
5757
)
5858

0 commit comments

Comments
 (0)