Skip to content

incompatible_no_rustc_sysroot_env #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
UebelAndre opened this issue Jan 17, 2024 · 1 comment · Fixed by #2790
Closed

incompatible_no_rustc_sysroot_env #2429

UebelAndre opened this issue Jan 17, 2024 · 1 comment · Fixed by #2790

Comments

@UebelAndre
Copy link
Collaborator

Rustc actions have historically defined a SYSROOT environment variable which points to the Rust sysroot. This flag is not consumed by rustc and is therefore unnecessary in this action. A --@rules_rust//rust/settings:incompatible_no_rustc_sysroot_env flag is being added to remove this.
@UebelAndre
Copy link
Collaborator Author

The use of this environment variable is also suspected to lead to clippy issues: #2418

@UebelAndre UebelAndre mentioned this issue Jun 25, 2024
Merged
@UebelAndre UebelAndre mentioned this issue Aug 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 13, 2024
@UebelAndre
Delete incompatible_no_rustc_sysroot_env (#2790)
0e2409e 
This flag has been flipped long enough and I haven't heard any
complaints.

closes #2429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete incompatible_no_rustc_sysroot_env UebelAndre/rules_rust
1 participant
@UebelAndre