Match prerelease versions with annotation wildcard (#1716)

Fixes #1690

Author: jfirebaugh

crate_universe/private/crate.bzl

@@ -90,7 +90,8 @@ def _annotation(
     """A collection of extra attributes and settings for a particular crate
 
     Args:
-        version (str, optional): The version or semver-conditions to match with a crate.
+        version (str, optional): The version or semver-conditions to match with a crate. The wildcard `*`
+            matches any version, including prerelease versions.
         additive_build_file_content (str, optional): Extra contents to write to the bottom of generated BUILD files.
         additive_build_file (str, optional): A file containing extra contents to write to the bottom of
             generated BUILD files.

crate_universe/src/config.rs

@@ -356,6 +356,16 @@ impl CrateId {
             return true;
         }
 
+        // If the version provided is the wildcard "*", it matches. Do not
+        // delegate to the semver crate in this case because semver does not
+        // consider "*" to match prerelease packages. That's expected behavior
+        // in the context of declaring package dependencies, but not in the
+        // context of declaring which versions of preselected packages an
+        // annotation applies to.
+        if self.version == "*" {
+            return true;
+        }
+
         // Next, check to see if the version provided is a semver req and
         // check if the package matches the condition
         if let Ok(semver) = VersionReq::parse(&self.version) {
@@ -497,6 +507,10 @@ mod test {
         id.version = "*".to_owned();
         assert!(id.matches(&package));
 
+        let mut prerelease = mock_cargo_metadata_package();
+        prerelease.version = cargo_metadata::semver::Version::parse("1.0.0-pre.0").unwrap();
+        assert!(id.matches(&prerelease));
+
         id.version = "<1".to_owned();
         assert!(!id.matches(&package));
     }

docs/crate_universe.md

@@ -518,7 +518,7 @@ A collection of extra attributes and settings for a particular crate
 
 | Name  | Description | Default Value |
 | :------------- | :------------- | :------------- |
-| <a id="crate.annotation-version"></a>version |  The version or semver-conditions to match with a crate.   |  `"*"` |
+| <a id="crate.annotation-version"></a>version |  The version or semver-conditions to match with a crate. The wildcard <code>*</code> matches any version, including prerelease versions.   |  `"*"` |
 | <a id="crate.annotation-additive_build_file"></a>additive_build_file |  A file containing extra contents to write to the bottom of generated BUILD files.   |  `None` |
 | <a id="crate.annotation-additive_build_file_content"></a>additive_build_file_content |  Extra contents to write to the bottom of generated BUILD files.   |  `None` |
 | <a id="crate.annotation-build_script_data"></a>build_script_data |  A list of labels to add to a crate's <code>cargo_build_script::data</code> attribute.   |  `None` |