Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define wheel version via file/target #1804

Open
mgosk opened this issue Mar 13, 2024 · 1 comment · May be fixed by #1807
Open

Define wheel version via file/target #1804

mgosk opened this issue Mar 13, 2024 · 1 comment · May be fixed by #1807

Comments

@mgosk
Copy link

mgosk commented Mar 13, 2024

🚀 feature request

Relevant Rules

  • py_wheel

Description

I would like use wheel version generated by other target.

Describe the solution you'd like


my_version_generator(
    name = "version"
    ...
)

py_wheel(
    name = "foo",
    version_file = ":version",
    ...
)

Solution should be a bit similiar to https://github.com/vaticle/bazel-distribution/blob/ebb4a9b342ec442c427705ec6a7919cce4c35c6e/maven/rules.bzl#L258

Describe alternatives you've considered

  • Generating version before build and passing via variable in volatile status. Solution is inconvenient for multiple modules and is against bazel design.
@mgosk mgosk changed the title Use wheel version from file/target Define wheel version via file/target Mar 13, 2024
Copy link

github-actions bot commented Sep 9, 2024

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Sep 9, 2024
@aignas aignas removed the Can Close? Will close in 30 days if there is no new activity label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants