You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When buildozer 8.0.0 runs fixes without the -stdout flag, it exits with status 3 and prints nothing when it has no changes to make. When it runs on the same BUILD file with the -stdout flag, it also outputs nothing to stdout and exits with status 0. This makes it ambiguous whether the output is missing because buildozer had nothing to do or because its altered output is legitimately an empty file.
My preference would be to have the -stdout flag always produce BUILD file content whether it was altered or not. If we need to differentiate those two cases then let's use the exit status to do that.
To reproduce this, run buildozer -stdout 'fix unusedLoads' //:__pkg__ on this project's workspace.
The text was updated successfully, but these errors were encountered:
When buildozer 8.0.0 runs fixes without the
-stdout
flag, it exits with status 3 and prints nothing when it has no changes to make. When it runs on the same BUILD file with the-stdout
flag, it also outputs nothing to stdout and exits with status 0. This makes it ambiguous whether the output is missing because buildozer had nothing to do or because its altered output is legitimately an empty file.My preference would be to have the
-stdout
flag always produce BUILD file content whether it was altered or not. If we need to differentiate those two cases then let's use the exit status to do that.To reproduce this, run
buildozer -stdout 'fix unusedLoads' //:__pkg__
on this project's workspace.The text was updated successfully, but these errors were encountered: