Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BASE_URL (or similar) for rolling/green releases #618

Open
novas0x2a opened this issue Oct 3, 2024 · 0 comments
Open

Support BASE_URL (or similar) for rolling/green releases #618

novas0x2a opened this issue Oct 3, 2024 · 0 comments
Labels
help wanted Needs help from external contributors P3 We're not considering working on this, but happy to review a PR. (No assignee)

Comments

@novas0x2a
Copy link

This is an additional feature request on top of #72; we want all of the binary downloads to pull through our transparent mirror. Currently, we're doing that via .bazeliskrc:

BAZELISK_BASE_URL=https://our.mirror/github.com/bazelbuild/bazel/releases/download

But I noticed that rolling and last_green don't use the BASE_URL, so they download directly (which makes sense, given that it would be tricky to use BASE_URL in a way that worked for multiple download types, since they come from different hosts with different path schemes)

Would it be possible to extend the functionality to support this? Not sure the best way, but one way I can think of would be to add a key to BAZELISK_FORMAT_URL that contains the URL that bazelisk would have used anyway, like maybe:

  • %H means the hostname (that would have been used if FORMAT_URL wasn't set)
  • %P means the path (same)

So then if I set BAZELISK_FORMAT_URL to https://our.mirror/%H/%P (and the DownloadRolling / DownloadAtCommit supported it) then I think that would do what I wanted?

@meteorcloudy meteorcloudy added help wanted Needs help from external contributors P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Needs help from external contributors P3 We're not considering working on this, but happy to review a PR. (No assignee)
Projects
None yet
Development

No branches or pull requests

2 participants