Skip to content

Commit 706b5f1

Browse files
fix tests
1 parent 0044523 commit 706b5f1

File tree

5 files changed

+15
-24
lines changed

5 files changed

+15
-24
lines changed

MODULE.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ use_repo(non_module_deps, "io_bazel_rules_scala_scala_reflect")
2121
use_repo(non_module_deps, "org_scalameta_semanticdb_scalac")
2222
use_repo(non_module_deps, "io_bazel_rules_scala_scala_tasty_core")
2323
use_repo(non_module_deps, "io_bazel_rules_scala_scala_asm")
24+
use_repo(non_module_deps, "io_bazel_rules_scala_scala_library_2")
2425
use_repo(non_module_deps, "io_bazel_rules_scala_org_openjdk_jmh_jmh_core")
2526
use_repo(non_module_deps, "io_bazel_rules_scala_org_openjdk_jmh_jmh_generator_asm")
2627
use_repo(non_module_deps, "io_bazel_rules_scala_org_openjdk_jmh_jmh_generator_reflection")

scala/private/phases/phase_dependency.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,11 @@ def _get_unused_deps_mode(ctx):
8585

8686
def _is_target_included(target, includes, excludes):
8787
for exclude in excludes:
88-
if target.startswith(exclude):
88+
if target.startswith(exclude) or target.startswith("@" + exclude):
8989
return False
9090

9191
for include in includes:
92-
if target.startswith(include):
92+
if target.startswith(include) or target.startswith("@" + include):
9393
return True
9494

9595
return False

test/shell/test_scala_library.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ test_scala_library_expect_better_failure_with_target_label_from_stamped_jar_on_m
177177

178178
test_scala_library_expect_better_failure_message_on_missing_transitive_dependency_labels_from_other_jvm_rules() {
179179
transitive_target='.*transitive_dependency_without_manifest.jar'
180-
direct_target='@//test_expect_failure/missing_direct_deps/internal_deps:unstamped_direct_java_provider_dependency'
180+
direct_target='@.*//test_expect_failure/missing_direct_deps/internal_deps:unstamped_direct_java_provider_dependency'
181181
test_target='//test_expect_failure/missing_direct_deps/internal_deps:unstamped_jar_dependent_on_some_java_provider'
182182

183183
expected_message="Unknown label of file $transitive_target which came from $direct_target"

test/shell/test_strict_dependency.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ test_plus_one_ast_analyzer_strict_deps() {
4141

4242
test_stamped_target_label_loading() {
4343
local test_target="//test_expect_failure/missing_direct_deps/external_deps:java_lib_with_a_transitive_external_dep"
44-
local expected_message="buildozer 'add deps @io_bazel_rules_scala_guava//:io_bazel_rules_scala_guava' ${test_target}"
44+
local expected_message="buildozer 'add deps @.*io_bazel_rules_scala_guava//:io_bazel_rules_scala_guava' ${test_target}"
4545

4646
test_expect_failure_or_warning_on_missing_direct_deps_with_expected_message \
4747
"${expected_message}" ${test_target} \
@@ -56,7 +56,7 @@ test_strict_deps_filter_excluded_target() {
5656

5757
test_strict_deps_filter_included_target() {
5858
local test_target="//test_expect_failure/missing_direct_deps/filtering:b"
59-
local expected_message="buildozer 'add deps @com_google_guava_guava_21_0//:com_google_guava_guava_21_0' ${test_target}"
59+
local expected_message="buildozer 'add deps @.*com_google_guava_guava_21_0//:com_google_guava_guava_21_0' ${test_target}"
6060

6161
test_expect_failure_or_warning_on_missing_direct_deps_with_expected_message \
6262
"${expected_message}" ${test_target} \
@@ -66,7 +66,7 @@ test_strict_deps_filter_included_target() {
6666

6767
test_demonstrate_INCORRECT_scala_proto_library_stamp() {
6868
local test_target="//test_expect_failure/missing_direct_deps/scala_proto_deps:uses_transitive_scala_proto"
69-
local incorrectly_stamped_expected_message="buildozer 'add deps @//test_expect_failure/missing_direct_deps/scala_proto_deps:some_proto' ${test_target}"
69+
local incorrectly_stamped_expected_message="buildozer 'add deps @.*//test_expect_failure/missing_direct_deps/scala_proto_deps:some_proto' ${test_target}"
7070

7171
# When stamping is fixed, expected stamp is:
7272
# local correctly_stamped_expected_message="buildozer 'add deps //test_expect_failure/missing_direct_deps/scala_proto_deps:some_scala_proto' ${test_target}"
@@ -79,7 +79,7 @@ test_demonstrate_INCORRECT_scala_proto_library_stamp() {
7979

8080
test_scala_proto_library_stamp_by_convention() {
8181
local test_target="//test_expect_failure/missing_direct_deps/scala_proto_deps:uses_transitive_scala_proto"
82-
local expected_message="buildozer 'add deps @//test_expect_failure/missing_direct_deps/scala_proto_deps:some_scala_proto' ${test_target}"
82+
local expected_message="buildozer 'add deps @.*//test_expect_failure/missing_direct_deps/scala_proto_deps:some_scala_proto' ${test_target}"
8383

8484
test_expect_failure_or_warning_on_missing_direct_deps_with_expected_message \
8585
"${expected_message}" ${test_target} \
@@ -89,7 +89,7 @@ test_scala_proto_library_stamp_by_convention() {
8989

9090
test_scala_proto_library_custom_phase_stamping() {
9191
local test_target="//test_expect_failure/missing_direct_deps/scala_proto_deps:uses_transitive_some_proto_custom_suffix"
92-
local expected_message="buildozer 'add deps @//test_expect_failure/missing_direct_deps/scala_proto_deps:some_proto_custom_suffix' ${test_target}"
92+
local expected_message="buildozer 'add deps .*@//test_expect_failure/missing_direct_deps/scala_proto_deps:some_proto_custom_suffix' ${test_target}"
9393

9494
test_expect_failure_or_warning_on_missing_direct_deps_with_expected_message \
9595
"${expected_message}" ${test_target} \

test_version/WORKSPACE.template

+6-16
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,6 @@ http_archive(
1212
],
1313
)
1414

15-
http_archive(
16-
name = "rules_proto",
17-
sha256 = "8e7d59a5b12b233be5652e3d29f42fba01c7cbab09f6b3a8d0a57ed6d1e9a0da",
18-
strip_prefix = "rules_proto-7e4afce6fe62dbff0a4a03450143146f9f2d7488",
19-
urls = [
20-
"https://mirror.bazel.build/github.com/bazelbuild/rules_proto/archive/7e4afce6fe62dbff0a4a03450143146f9f2d7488.tar.gz",
21-
"https://github.com/bazelbuild/rules_proto/archive/7e4afce6fe62dbff0a4a03450143146f9f2d7488.tar.gz",
22-
],
23-
)
24-
25-
load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
26-
27-
rules_proto_dependencies()
28-
29-
rules_proto_toolchains()
30-
3115
local_repository(
3216
name = "io_bazel_rules_scala",
3317
path = "../../"
@@ -42,6 +26,12 @@ load("@io_bazel_rules_scala//scala:scala.bzl", "scala_repositories")
4226

4327
scala_repositories(fetch_sources = True)
4428

29+
load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
30+
31+
rules_proto_dependencies()
32+
33+
rules_proto_toolchains()
34+
4535
load(":scrooge_repositories.bzl", "scrooge_repositories")
4636
${twitter_scrooge_repositories}
4737

0 commit comments

Comments
 (0)