Fix test_dependency_versions.sh on macOS, Windows

Copied the setup for the Windows `test_rules_scala` job to the Windows
`test_dependency_versions` job. Replaced `cp "${test_files[@]}" .` with
copying the list of files directly instead of keeping them in an array.

The Linux job passed. The Windows job didn't run the script at all. The
macOS build broke in a way I've not seen while developing locally:

```txt
cp:
(/Users/buildkite/builds/bk-macos-intel-m3q2/bazel/rules-scala-scala/deps/test/*.bzl
/Users/buildkite/builds/bk-macos-intel-m3q2/bazel/rules-scala-scala/examples/testing/multi_frameworks_toolchain/example/*.scala
/Users/buildkite/builds/bk-macos-intel-m3q2/bazel/rules-scala-scala/test/jmh/data.txt
/Users/buildkite/builds/bk-macos-intel-m3q2/bazel/rules-scala-scala/test/proto/standalone.proto
/Users/buildkite/builds/bk-macos-intel-m3q2/bazel/rules-scala-scala/test/src/main/scala/scalarules/test/twitter_scrooge/thrift/thrift2/thrift3/Thrift3.thrift):
No such file or directory
```

Author: mbland

.bazelci/presubmit.yml

@@ -130,5 +130,10 @@ tasks:
   dependency_versions_windows:
     name: "./test_dependency_versions"
     platform: windows
-    shell_commands:
-    - "./test_dependency_versions.sh"
+    environment:      
+      MSYS2_ARG_CONV_EXCL: "*"
+    batch_commands:
+    - "set PATH=/usr/bin;%PATH%" #Make sure bash uses msys commands over windows commands. (i.e. find).
+    - "bash -lc \"pacman --noconfirm --needed -S libxml2\"" #tests require xmllint
+    - "bash test_dependency_versions.sh"
+

test_dependency_versions.sh

@@ -143,14 +143,13 @@ do_build_and_test() {
     "${dir}/deps/test/MODULE.bazel.template" >MODULE.bazel
 
   # Copy files needed by the test targets
-  local test_files=(
-    "${dir}"/deps/test/*.{scala,bzl}
-    "${dir}"/examples/testing/multi_frameworks_toolchain/example/*.scala
-    "${dir}"/test/jmh/{TestBenchmark.scala,data.txt}
-    "${dir}"/test/proto/standalone.proto
-    "${dir}"/test/src/main/scala/scalarules/test/twitter_scrooge/thrift/thrift2/thrift3/Thrift3.thrift
-  )
-  cp "${test_files[@]}" .
+  cp \
+    "${dir}"/deps/test/*.{scala,bzl} \
+    "${dir}"/examples/testing/multi_frameworks_toolchain/example/*.scala \
+    "${dir}"/test/jmh/{TestBenchmark.scala,data.txt} \
+    "${dir}"/test/proto/standalone.proto \
+    "${dir}"/test/src/main/scala/scalarules/test/twitter_scrooge/thrift/thrift2/thrift3/Thrift3.thrift \
+    .
 
   set -e
   bazel build //...