fix: Allow cuda_test to specify the data attribute. (#314)

bgianfo · web-flow · commit 1b36a264f61f · 2025-01-27T15:44:33.000+08:00
The native.cc_test rule has a `data` attribute that is not exposed in
the cuda_test rule. This change allows the cuda_test rule to specify the
`data` attribute, and plumb it down to the native.cc_test rule.
diff --git a/cuda/private/macros/cuda_test.bzl b/cuda/private/macros/cuda_test.bzl
@@ -14,7 +14,7 @@ def cuda_test(name, **attrs):
     }
 
     # https://bazel.build/reference/be/common-definitions?hl=en#common-attributes-tests
-    cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local"]
+    cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local", "data"]
 
     cuda_library_attrs = {k: v for k, v in attrs.items() if k not in cc_test_only_attrs}
     for attr in cuda_library_only_attrs_defaults:

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ def cuda_test(name, **attrs):`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`# https://bazel.build/reference/be/common-definitions?hl=en#common-attributes-tests`
`17`		`- cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local"]`
	`17`	`+ cc_test_only_attrs = ["args", "env", "env_inherit", "size", "timeout", "flaky", "shard_count", "local", "data"]`
`18`	`18`
`19`	`19`	`cuda_library_attrs = {k: v for k, v in attrs.items() if k not in cc_test_only_attrs}`
`20`	`20`	`for attr in cuda_library_only_attrs_defaults:`