Skip to content

Impossible to see selected text on terminal in Kanagawa theme #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mdcarreira opened this issue May 7, 2025 · 4 comments · May be fixed by #469
Open

Impossible to see selected text on terminal in Kanagawa theme #450

mdcarreira opened this issue May 7, 2025 · 4 comments · May be fixed by #469

Comments

@mdcarreira
Copy link

In Kanagawa theme, when text is selected, the theme only changes its color to white. If the original text is already white, the selection becomes invisible.

For example:

Image

Image

As you can see on the last few lines, unless the text has a color other than white, it's impossible to see the selection.

I recommend setting a light gray background for selected text to make it visible regardless of text color.
@Kasui92
Copy link
Contributor

Kasui92 commented May 8, 2025

Actually, the selection (and copy) via mouse is not highlighted for Kanagawa... as well as for any theme except for the white text.

I went to the zellij documentation to understand how to do it and I discovered, looking at the repository, that they actually changed the way of managing the themes from this way (now legacy for them) to this one.

Using these styles, the highlighted texts appear.

Maybe we can think about a migration of the zellij themes?

@mdcarreira
Copy link
Author

Thanks for your finding @Kasui92! I changed my ~./config/zellij/themes/kanagawa.kdl to the new theme definition you pointed out and it worked like a charm!

Image

@Kasui92
Copy link
Contributor

Kasui92 commented May 8, 2025

You're welcome!
I'm preparing a PR to fix all the themes

@mdcarreira
Copy link
Author

Sweet! Feel free to close this issue when you are done 😉

@Kasui92 Kasui92 mentioned this issue May 8, 2025
Merged
@Kasui92 Kasui92 linked a pull request May 27, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reapply "Updated Zellij themes with new specs" Kasui92/omarell
2 participants
@Kasui92 @mdcarreira