Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add bool return to setFlag(), markMailAsRead(), etc. #706

Open
loekvangool opened this issue Mar 3, 2023 · 2 comments
Open

[Feature Request] Add bool return to setFlag(), markMailAsRead(), etc. #706

loekvangool opened this issue Mar 3, 2023 · 2 comments
Labels
needs investigation This will be tested / debugged or checked out.

Comments

@loekvangool
Copy link

Is your feature request related to a problem? Please describe.
setFlag() and its invokers like markMailAsRead() return void at the moment, can they instead return a bool?
@loekvangool loekvangool added the needs investigation This will be tested / debugged or checked out. label Mar 3, 2023
@michalcharvat
Copy link

Question is if it is necessary because when there is something wrong when you try set or clear the flag, you receive UnexpectedValueException

@loekvangool
Copy link
Author

Thanks for the reply. Saw that, however writing try/catch blocks is IMO quite cumbersome to implement, versus return values.

I do understand that it is a style difference, not right/wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation This will be tested / debugged or checked out.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loekvangool @michalcharvat