Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for annotation + nodeselector issue #16

Open
eliorso opened this issue Mar 20, 2022 · 1 comment
Open

Missing support for annotation + nodeselector issue #16

eliorso opened this issue Mar 20, 2022 · 1 comment

Comments

@eliorso
Copy link

eliorso commented Mar 20, 2022

The currect daemonset.yaml does support adding of Annotations.

I had to update the file as follow:
{{- with .Values.Annotations }}
annotations:
{{ toYaml . | nindent 8 }}
{{- end }}

Another bug that i found when using node selector, the useHostNetwork failed, fixed by :
{{ toYaml .Values.resources | indent 10 }}
hostNetwork: {{ .Values.useHostNetwork }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{ toYaml . | indent 8 }}
{{- end }}

@danielmotaleite
Copy link

i fixed the nodeSelector like this, as the main issue is the different scope inside the nodeSelector step

{{ toYaml .Values.resources | indent 10 }}
{{- $hostnetwork := .Values.useHostNetwork }}
    {{- with .Values.nodeSelector }}
      hostNetwork: {{ $hostnetwork }}
      nodeSelector:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants