From ee041625399875bf44db08c4d44c7bc445c53e9a Mon Sep 17 00:00:00 2001 From: taobun Date: Thu, 17 Sep 2020 17:57:46 +0700 Subject: [PATCH 1/2] add commission check before withdraw when export --- chain/app/export.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chain/app/export.go b/chain/app/export.go index f9cbd2d739..e196d7bdea 100644 --- a/chain/app/export.go +++ b/chain/app/export.go @@ -60,6 +60,10 @@ func (app *BandApp) prepForZeroHeightGenesis(ctx sdk.Context, jailWhiteList []st // withdraw all validator commission app.StakingKeeper.IterateValidators(ctx, func(_ int64, val staking.ValidatorI) (stop bool) { + accumCommission := app.DistrKeeper.GetValidatorAccumulatedCommission(ctx, val.GetOperator()) + if accumCommission.IsZero() { + return false + } _, err := app.DistrKeeper.WithdrawValidatorCommission(ctx, val.GetOperator()) if err != nil { log.Fatal(err) From d1952fc6aad0e9f1a57cb212dde3574b54513eec Mon Sep 17 00:00:00 2001 From: taobun Date: Thu, 17 Sep 2020 18:03:30 +0700 Subject: [PATCH 2/2] add changelog --- CHANGELOG_UNRELEASED.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG_UNRELEASED.md b/CHANGELOG_UNRELEASED.md index 3e291cad0a..4a1e5e7433 100644 --- a/CHANGELOG_UNRELEASED.md +++ b/CHANGELOG_UNRELEASED.md @@ -12,6 +12,8 @@ ### Chain (Non-consensus) +- (bugs) [\#2649](https://github.com/bandprotocol/bandchain/pull/2649) Add commission check before withdraw when export + ### Yoda ### Emitter & Flusher