-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to an sdk package #95
Comments
Yes, I agree. Along those lines, I can see it allowing for other clients to participate in the network while maintaining interoperability. Just because clients speak the same protocol or api, doesn't mean they work well together. It would be nice if there was just one SDK, but mobile generally requires storage for offline viewing. Supporting both modes within a single SDK may be messy. There are a few new features, maybe bundled as separate apps, that I would like to include in an SDK. Perhaps it's over designing, but it goes to my hopes that the databag backend can be more general than a message service.
Thank you for the suggestion! |
That would require an optional Interoperability with other sqlite libraries isn't necessary as a non react native library exists too. https://github.com/asnando/sqlite-storage |
Thank you for this reference. I have a rough idea what the API should look like now, but am not yet sure how much the refactor effort will be. I will likely start the SDK work in a month or two, after I complete several other commitments. Would you be willing to review the SDK API after I finish a draft? |
Definitely 👍 I'd suggest cut-pasting from frontend to sdk then altering from there, that way you never have a commit where everything is broken. |
I need to move the typescript changes into a branch until I can fix it: Deploying the latest gives me: 'Uncaught ReferenceError: require is not defined' I thought I had tested it, but I must have been using a stale build. |
I'll see if I can work on the docker development env, you seem to be using production builds instead of the local code. I haven't yet got it working properly (on a Mac machine) |
It might not be worth this effort. When I start the SDK refactor work, I will make sure to use typescript. |
Instead of reimplementing common chat functionality on each client, create an sdk that is plugged into mobile and web apps.
This could handle;
The sdk should not contain any react. Instead async and callbacks should be used
This is just an example of functionality not structure.
With an sdk the react could move to a more passive role of displaying data when the sdk says so.
The text was updated successfully, but these errors were encountered: