Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward pass of grid_grad is wrong (test fails) #29

Open
balbasty opened this issue Dec 10, 2020 · 0 comments
Open

Backward pass of grid_grad is wrong (test fails) #29

balbasty opened this issue Dec 10, 2020 · 0 comments
Labels
bug Something isn't working language: c++ Relates to C++/CUDA code

Comments

@balbasty
Copy link
Owner

The test that checks that analytical and numerical gradients are identical fails for grid_grad. There must be an error in the c++ code.
@balbasty balbasty added bug Something isn't working language: c++ Relates to C++/CUDA code labels Dec 10, 2020
@balbasty balbasty mentioned this issue Dec 10, 2020
Merged
balbasty added a commit that referenced this issue Dec 10, 2020
@balbasty
Continuous integration (#31): first working version
7d66ff6 
* compilation is tested on a matrix of Python x PyTorch x CUDA versions (only on ubuntu for the moment) and triggered when c++/cuda files change (or when setup.py changes)

* tests are run on two versions of PyTorch (on cpu only since the servers do not have a gpu) and triggered when any of the library files change (nitorch/**)

* I had to disable one test that failed (grid_grad -> see #29)

* I also had to disable compilation on Python 3.7 which fails weirdly (see #30)

* Compilation on mac and windows is not there yet (needs a lot more work)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working language: c++ Relates to C++/CUDA code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balbasty