docs: update documentation #115
Conversation
jmleroux
commented
Oct 27, 2025
jmleroux
commented
- Update documentation about Docker usage for dev
- Introduce Makefile instead of Composer scripts. I believe this is the most widespread practice in the Symfony ecosystem.
- Update README with some generated images
- Mutualize Docker compose configuration
| - name: Run tests | ||
| run: CONTAINER=${{ matrix.container }} make tests | ||
|
|
||
| tests-php84: |
There was a problem hiding this comment.
Extracted from the matrix while it is not stable
| - name: Coding Standard Checks | ||
| run: docker compose run --rm ${{ matrix.container }} bin/php-cs-fixer fix --verbose --diff --dry-run | ||
| - name: Run tests | ||
| run: CONTAINER=${{ matrix.container }} make tests |
There was a problem hiding this comment.
Running tests with make will also validate the target works as expected
|
See kartsims/easysvg#39 for an EasySVG fix for PHP 8.4 |
I'try to have some news about the fix. |
From what I see in the linked issue, there's only a deprecation. |
.github/workflows/php.yml
Outdated
| run: | | ||
| docker compose run --rm php84 bin/php-cs-fixer fix --verbose --diff --dry-run | ||
| docker compose run --rm php84 bin/phpunit | ||
| docker compose run --rm php84 php -d error_reporting='E_ALL & ~E_DEPRECATED' bin/behat --snippets-for |
There was a problem hiding this comment.
I could also hide deprecation for all tests. But it's like hiding the dust under the carpet.
Thoughts?
There was a problem hiding this comment.
Hiding all deprecations for php 8.4 is acceptable for me. We can still remove the hiding later, when hopefully easysvg will have solved its problems.
|
Last commit is a demo with deprecation ignored for all behat tests. |
2 participants
