Skip to content

Commit f4c1756

Browse files
committed
fix: fix tests make target by making it a phony target. Fix phpunit instead of phpspec
1 parent 8831930 commit f4c1756

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.github/workflows/php.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,5 @@ jobs:
5555
- name: Install dependencies
5656
run: docker compose run -u $(id -u):$(id -g) --rm ${{ matrix.container }} composer install --prefer-dist --no-progress
5757

58-
- name: Coding Standard Checks
59-
run: docker compose run --rm ${{ matrix.container }} bin/php-cs-fixer fix --verbose --diff --dry-run
60-
61-
- name: Unit tests
62-
run: docker compose run --rm ${{ matrix.container }} ./bin/phpunit
63-
64-
- name: Run behat tests
65-
run: docker compose run --rm ${{ matrix.container }} ./bin/behat --snippets-for
58+
- name: Run tests
59+
run: CONTAINER=${{ matrix.container }} make tests

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
CONTAINER ?= php84
22
DOCKER_RUN=docker compose run --rm $(CONTAINER)
33

4+
.PHONY: setup tests matrix-tests doc-images
5+
46
setup:
57
docker compose build $(CONTAINER)
68
$(DOCKER_RUN) composer update
79

10+
811
tests:
912
docker compose run --rm $(CONTAINER) bin/php-cs-fixer fix --verbose --diff --dry-run
10-
docker compose run --rm $(CONTAINER) bin/phpspec run --format=pretty
13+
docker compose run --rm $(CONTAINER) bin/phpunit
1114
docker compose run --rm $(CONTAINER) bin/behat --snippets-for
1215

1316
matrix-tests:

0 commit comments

Comments
 (0)