Skip to content

Ensure inline type hints use /** @var */ syntax #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
quicksketch opened this issue Apr 11, 2025 · 1 comment · May be fixed by #23
Open

Ensure inline type hints use /** @var */ syntax #22

quicksketch opened this issue Apr 11, 2025 · 1 comment · May be fixed by #23

Comments

@quicksketch
Copy link
Member

This is a companion issue to the core issue at backdrop/backdrop-issues#6876. Core was using inconsistent type hinting such as /* @var Block $block */ vs /** @var Block $block */, with the second example being more supported by some developer tools and IDEs. We standardized on the second format. It would be great if PHPCS would find an catch the first syntax and report it as incorrect.
@quicksketch quicksketch mentioned this issue Apr 11, 2025
Closed
indigoxela added a commit that referenced this issue Apr 12, 2025
@indigoxela
Issue #22: Enforce type hint inline comment syntax
26c0368
@indigoxela indigoxela linked a pull request Apr 12, 2025 that will close this issue
Open
@indigoxela
Copy link
Collaborator

Here we go: #23

Does this behave as desired @quicksketch (I'm no expert on writing phpcs sniffs)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #22: Enforce type hint inline comment syntax backdrop-ops/phpcs
2 participants
@quicksketch @indigoxela