fix:派蒙检测改为调用bv，调整相关配置默认值 - #3529
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. Walkthrough本次变更调整派蒙辅助战斗结束检测的默认配置。检测逻辑改用 Changes派蒙辅助战斗结束检测
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR switches end-of-battle Paimon detection to the shared avatar-region check and disables that check by default while increasing its delay; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile Summary此 PR 将自动战斗结束阶段的派蒙检测由固定像素判断改为复用
Confidence Score: 4/5此 PR 看起来可以合并，但应同步更新两个设置界面的默认值说明，避免误导用户。 识别调用与现有全帧视觉识别契约相符，未发现明确的运行时阻塞问题；当前确定的问题仅是配置默认值与用户界面说明不一致。 Files Needing Attention: BetterGenshinImpact/GameTask/AutoFight/AutoFightConfig.cs、BetterGenshinImpact/View/Pages/TaskSettingsPage.xaml、BetterGenshinImpact/View/Pages/View/ScriptGroupConfigView.xaml
|
| Filename | Overview |
|---|---|
| BetterGenshinImpact/GameTask/AutoFight/AutoFightTask.cs | 派蒙辅助检测改为使用全帧 ImageRegion 调用 Bv.IsInMainUi，截图尺寸和识别输入契约保持一致，未确认阻塞性问题。 |
| BetterGenshinImpact/GameTask/AutoFight/AutoFightConfig.cs | 默认开关和延迟已调整，但相关设置页面仍展示旧的默认值说明。 |
Prompt To Fix All With AI
### Issue 1
BetterGenshinImpact/GameTask/AutoFight/AutoFightConfig.cs:127-133
**默认值说明未同步**
这里已将派蒙辅助检测的默认值改为禁用、延迟改为 0.2 秒，但 `TaskSettingsPage.xaml` 和 `ScriptGroupConfigView.xaml` 仍显示“默认开启”和“默认为0.1秒”，会让使用新建或重置配置的用户误判实际行为；请同步更新这两个界面的帮助文本。
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix: 派蒙检测改为调用bv，调整相关配置默认值" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| private bool _paimonEndCheckEnabled = false; | ||
|
|
||
| /// <summary> | ||
| /// 派蒙辅助检测延时（秒），默认为0.075秒 | ||
| /// 派蒙辅助检测延时（秒），默认为0.2秒 | ||
| /// </summary> | ||
| [ObservableProperty] | ||
| private double _paimonEndCheckDelay = 0.075; | ||
| private double _paimonEndCheckDelay = 0.2; |
There was a problem hiding this comment.
这里已将派蒙辅助检测的默认值改为禁用、延迟改为 0.2 秒，但 TaskSettingsPage.xaml 和 ScriptGroupConfigView.xaml 仍显示“默认开启”和“默认为0.1秒”，会让使用新建或重置配置的用户误判实际行为；请同步更新这两个界面的帮助文本。
Prompt To Fix With AI
This is a comment left during a code review.
Path: BetterGenshinImpact/GameTask/AutoFight/AutoFightConfig.cs
Line: 127-133
Comment:
**默认值说明未同步**
这里已将派蒙辅助检测的默认值改为禁用、延迟改为 0.2 秒，但 `TaskSettingsPage.xaml` 和 `ScriptGroupConfigView.xaml` 仍显示“默认开启”和“默认为0.1秒”，会让使用新建或重置配置的用户误判实际行为；请同步更新这两个界面的帮助文本。
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
2 participants
改动内容
将战斗结束检测中的派蒙辅助检测从「固定像素坐标点判断」改为「复用 Bv 的派蒙头像区域检测」，并调整相关配置默认值。
1. 派蒙检测改为调用 bv
2. 调整配置默认值
修改文件
Summary by CodeRabbit