fixed the farfield plot

Author: laylagi

examples/antenna/antenna.json renamed to examples/antenna/antenna_halfwave_dipole.json

@@ -3,12 +3,12 @@
     {
         "Type": "Driven",
         "Verbose": 2,
-        "Output": "postpro/antenna"
+        "Output": "postpro/antenna_halfwave_dipole"
     }
     ,
     "Model":
     {
-        "Mesh": "mesh/antenna.msh",
+        "Mesh": "mesh/antenna_halfwave_dipole.msh",
         "L0": 1.0  // 1 meter
     },
     "Domains":

examples/antenna/antenna_dipole.json renamed to examples/antenna/antenna_short_dipole.json

@@ -3,11 +3,11 @@
     {
         "Type": "Driven",
         "Verbose": 2,
-        "Output": "postpro/antenna_dipole"
+        "Output": "postpro/antenna_short_dipole"
     },
     "Model":
     {
-        "Mesh": "mesh/antenna_dipole.msh",
+        "Mesh": "mesh/antenna_short_dipole.msh",
         "L0": 1.0
     },
     "Domains":
@@ -35,7 +35,7 @@
         "Postprocessing": {
             "FarField": {
                 "Attributes": [1],
-                "NSample": 64800,
+                "NSample": 100,
                 "ThetaPhis": [[35, 20]]
             }
         }

examples/antenna/mesh/antenna.msh renamed to examples/antenna/mesh/antenna_halfwave_dipole.msh

@@ -10,7 +10,7 @@ a thin gap. In the thin gap, there is a flat rectangle that connects the cylinde
 can is used as a lumped port.
 
 The generated mesh contains two regions:
-1. A 3D volume region (the air/vacuum space inside the outer sphere)
+1. A 3D volume region (the space inside the sphere)
 2. A large outer spherical boundary (typically set to "absorbing" boundary conditions)
 
 ## Prerequisites
@@ -109,13 +109,13 @@ function generate_antenna_mesh(;
     verbose::Integer=5,
     gui::Bool=false
 )
-    # We will create this mesh with a simple approach. We create the 3D outer
+    # We will create this mesh with a simple approach. We create the 3D
     # sphere only, which produces:
     # - 1 3D entity (the domain)
     # - 1 2D entity (the outer boundary)
     #
-    # After creation, we add them to the correct gmsh physical groups. Finally, we
-    # control mesh size and generate the mesh.
+    # After creating, we add them to the correct gmsh physical groups. Finally, we
+    # control mesh size with a mesh size field and generate the mesh.
 
     # Boilerplate
     gmsh.initialize()
@@ -136,15 +136,15 @@ function generate_antenna_mesh(;
     n_circle = 12
     # How many elements per wavelength on the outer sphere.
     # Higher number = higher resolution.
-    n_farfield = 10
+    n_farfield = 3
 
-    # Create geometry: outer sphere only.
+    # Create geometry
     outer_boundary = kernel.addSphere(0, 0, 0, outer_boundary_radius)
 
     # Synchronize CAD operations with Gmsh model.
     kernel.synchronize()
 
-    # Since we only have a sphere, we can directly get the entities.
+    # Helper functions to identify the various components.
     all_2d_entities = kernel.getEntities(2)
     all_3d_entities = kernel.getEntities(3)
 

examples/antenna/mesh/antenna_dipole.msh renamed to examples/antenna/mesh/antenna_short_dipole.msh

@@ -10,7 +10,17 @@ The 3D relative radiation pattern plot depicts a 3D surface whose distance from
 the center is proportional to the strength of the electric field.
 
 Usage:
-    julia plot_farfield.jl [filename]
+    julia plot_farfield.jl [model=<model_type> file=<filename>]
+
+Arguments:
+    model=<model_type>  - Dipole model type: "antenna_short_dipole" or "antenna_halfwave_dipole"
+    file=<filename>     - Path to farfield file
+
+Note: If any arguments are provided, both model= and file= must be specified.
+
+Defaults:
+    model: antenna_halfwave_dipole
+    file: postpro/antenna_halfwave_dipole/farfield-rE.csv
 
 Requires CSV, DataFrames, and CairoMakie.
 """
@@ -111,24 +121,47 @@ function compute_db(magnitude)
 end
 
 """
-    generate_theoretical_dipole()
+    generate_theoretical_dipole(model_type="antenna_halfwave_dipole")
+
+Return angles and patterns for theoretical dipole radiation pattern.
+
+Arguments:
+    model_type - "antenna_short_dipole" for electrical current dipole or "antenna_halfwave_dipole" for half-wave dipole
 
-Return angles and angles for theoretical half-wave dipole radiation pattern.
+For antenna_short_dipole (z-oriented electrical current dipole):
+Based on geosci.xyz far-field analytical solution for z-oriented dipole.
+- E-plane (xz): |E_θ|² ∝ |sin(θ)|² (nulls along dipole axis, maxima perpendicular)
+- H-plane (xy): |H_φ|² ∝ constant (omnidirectional)
 
-  - E-plane: [cos(π/2 * cos(θ)) / sin(θ)]²
-  - H-plane: omnidirectional (constant)
+For antenna_halfwave_dipole:
+- E-plane: [cos(π/2 * cos(θ)) / sin(θ)]²
+- H-plane: omnidirectional (constant)
 """
-function generate_theoretical_dipole()
+function generate_theoretical_dipole(model_type="antenna_halfwave_dipole")
     angles = 0:360
 
-    # E-plane: [cos(π/2 * cos(θ)) / sin(θ)]²
-    eplane = zeros(length(angles))
-    for (i, θ_deg) in enumerate(angles)
-        θ_rad = deg2rad(θ_deg)
-        sin_θ = sin(θ_rad)
-        if abs(sin_θ) > 1e-6
-            eplane[i] = abs(cos(π/2 * cos(θ_rad)) / sin_θ)
+    if model_type == "antenna_short_dipole"
+        # E-plane: sin(θ)²
+        eplane = zeros(length(angles))
+        for (i, θ_deg) in enumerate(angles)
+            θ_rad = deg2rad(θ_deg)
+            sin_θ = sin(θ_rad)
+            if abs(sin_θ) > 1e-6
+                eplane[i] = abs(sin_θ)
+            end
         end
+    elseif model_type == "antenna_halfwave_dipole"
+        # E-plane: [cos(π/2 * cos(θ)) / sin(θ)]²
+        eplane = zeros(length(angles))
+        for (i, θ_deg) in enumerate(angles)
+            θ_rad = deg2rad(θ_deg)
+            sin_θ = sin(θ_rad)
+            if abs(sin_θ) > 1e-6
+                eplane[i] = abs(cos(π/2 * cos(θ_rad)) / sin_θ)
+            end
+        end
+    else
+        error("Unknown model_type: $model_type. Use 'antenna_short_dipole' or 'antenna_halfwave_dipole'")
     end
 
     # H-plane: omnidirectional
@@ -138,15 +171,15 @@ function generate_theoretical_dipole()
 end
 
 """
-    polar_plots(data, label, filename = "farfield_polar.png")
+    polar_plots(data, label, model_type="halfwave_dipole", filename="farfield_polar.png")
 
-Plot the polar radiation patterns and the expected half-dipole pattern.
+Plot the polar radiation patterns and the expected dipole pattern.
 """
-function polar_plots(data, label, filename="farfield_polar.png")
+function polar_plots(data, label, model_type="halfwave_dipole", filename="farfield_polar.png")
     e_angles, e_mag = extract_eplane(data)
     h_angles, h_mag = extract_hplane(data)
 
-    theo_angles, theo_eplane, _, theo_hplane = generate_theoretical_dipole()
+    theo_angles, theo_eplane, _, theo_hplane = generate_theoretical_dipole(model_type)
     theo_e_db = compute_db(theo_eplane)
     theo_h_db = compute_db(theo_hplane)
 
@@ -213,7 +246,7 @@ function polar_plots(data, label, filename="farfield_polar.png")
 end
 
 """
-    three_d_plot(data, label, filename = "farfield_3d.png")
+    three_d_plot(data, label, filename="farfield_3d.png")
 
 Plot a 3D representation of the strength of the electric field.
 
@@ -239,16 +272,70 @@ function three_d_plot(data, label, filename="farfield_3d.png")
 end
 
 function main()
-    filename = length(ARGS) > 0 ? ARGS[1] : "postpro/farfield-rE.csv"
+    # Set defaults
+    model_type = "antenna_halfwave_dipole"
+    filename = "postpro/antenna_halfwave_dipole/farfield-rE.csv"
+
+    # Check if any arguments provided
+    if length(ARGS) == 0
+        # Use defaults - no arguments provided
+    elseif length(ARGS) == 2
+        # Both arguments must be provided
+        has_model = false
+        has_file = false
+
+        # Parse named arguments
+        for arg in ARGS
+            if startswith(arg, "model=")
+                model_type = split(arg, "=", limit=2)[2]
+                has_model = true
+            elseif startswith(arg, "file=")
+                filename = split(arg, "=", limit=2)[2]
+                has_file = true
+            else
+                println("Error: Invalid argument '$arg'")
+                println("Usage: julia --project plot_farfield.jl [model=<model_type> file=<filename>]")
+                println("Valid model types: 'antenna_short_dipole', 'antenna_halfwave_dipole'")
+                println("Examples:")
+                println("  julia plot_farfield.jl")
+                println("  julia plot_farfield.jl model=antenna_short_dipole file=data.csv")
+                return
+            end
+        end
+
+        # Ensure both arguments were provided
+        if !has_model || !has_file
+            println("Error: If arguments are provided, both model= and file= must be specified")
+            println("Usage: julia --project plot_farfield.jl [model=<model_type> file=<filename>]")
+            println("Examples:")
+            println("  julia plot_farfield.jl")
+            println("  julia plot_farfield.jl model=antenna_short_dipole file=data.csv")
+            return
+        end
+    else
+        println("Error: If arguments are provided, both model= and file= must be specified")
+        println("Usage: julia --project plot_farfield.jl [model=<model_type> file=<filename>]")
+        println("Examples:")
+        println("  julia plot_farfield.jl")
+        println("  julia plot_farfield.jl model=antenna_short_dipole file=data.csv")
+        return
+    end
+
+    if !(model_type in ["antenna_short_dipole", "antenna_halfwave_dipole"])
+        println("Error: Invalid model_type '$model_type'")
+        println("Valid options: 'antenna_short_dipole', 'antenna_halfwave_dipole'")
+        println("Usage: julia --project plot_farfield.jl [model=<model_type> file=<filename>]")
+        return
+    end
 
     if !isfile(filename)
         println("Error: File '$filename' not found")
-        println("Usage: julia --project plot_farfield.jl [filename]")
-        println("Default filename: postpro/farfield-E.csv")
+        println("Usage: julia --project plot_farfield.jl [model=<model_type> file=<filename>]")
         return
     end
 
     println("Reading farfield data from: $filename")
+    println("Using dipole model: $model_type")
 
     # Read the entire data file into a DataFrame
     df = CSV.read(filename, DataFrame)
@@ -268,8 +355,11 @@ function main()
         data = filter(row -> row["f"] == freq, df)
     end
 
-    polar_plots(data, label)
-    three_d_plot(data, label)
+    polar_filename = "farfield_polar_$(model_type).png"
+    three_d_filename = "farfield_3d_$(model_type).png"
+
+    polar_plots(data, label, model_type, polar_filename)
+    three_d_plot(data, label, three_d_filename)
     return nothing
 end