Repository navigation
Commit 09d88d7
authored
fix(billing-cost-management-mcp-server): storage-lens validation errors carry error_type; state Trino dialect and string CSV columns (#4950)
The two local validation failures in storage_lens_run_query (a query that is
not a single read-only SELECT, and a missing manifest location) returned
format_response('error', {}, message) with no error_type, so the response had
error_type=None and the retry guidance fell back to do_not_retry. They now
pass error_type='validation_error', operation='storage_lens_run_query' and
service='Storage Lens', so callers get retry_strategy=modify_request like the
other tools' argument errors.
The description said "Use standard SQL syntax for Athena queries". That line
now says the dialect is Athena engine version 3 (Trino SQL) and that every
column of a CSV export is a string, so numbers need a cast, e.g.
SUM(CAST(metric_value AS BIGINT)). The module docstring pointed at
resources/storage_lens_metrics_reference.md, which the package does not ship;
it now points at the tool description.
No parameter, type or default changes.1 parent 4fa757d commit 09d88d7
2 files changed
Lines changed: 78 additions & 3 deletions
File tree
- src/billing-cost-management-mcp-server
- awslabs/billing_cost_management_mcp_server/tools
- tests/tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
797 | 797 | | |
798 | 798 | | |
799 | 799 | | |
800 | | - | |
| 800 | + | |
801 | 801 | | |
802 | 802 | | |
803 | 803 | | |
| |||
923 | 923 | | |
924 | 924 | | |
925 | 925 | | |
926 | | - | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
927 | 934 | | |
928 | 935 | | |
929 | 936 | | |
| |||
932 | 939 | | |
933 | 940 | | |
934 | 941 | | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
935 | 945 | | |
936 | 946 | | |
937 | 947 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1443 | 1443 | | |
1444 | 1444 | | |
1445 | 1445 | | |
| 1446 | + | |
| 1447 | + | |
| 1448 | + | |
| 1449 | + | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
1446 | 1511 | | |
1447 | 1512 | | |
1448 | 1513 | | |
| |||
0 commit comments