Repository navigation
Commit 02cd0aa
authored
fix(billing-cost-management-mcp-server): commit session-sql writes via conn.in_transaction (#4860)
The session-sql tool decided whether to commit using a keyword-prefix
check on the query text (startswith INSERT/UPDATE/DELETE/CREATE/DROP/
ALTER). That check misses writes that sqlite3 still runs inside an
implicit transaction:
- comment-prefixed DML, e.g. "/* c */ INSERT ...", because .strip()
does not remove a leading comment, so startswith('INSERT') is False
- REPLACE statements, which are valid SQLite DML but absent from the
keyword list
For these, the implicit transaction was opened but never committed, so
the write was silently rolled back when the connection closed while the
tool still returned success.
Replace the prefix check with `if conn.in_transaction: conn.commit()`,
which reflects the engine's actual transaction state and commits exactly
when there is uncommitted work. Add durability regression tests for a
comment-prefixed INSERT and REPLACE (read back on a fresh connection)
plus a plain INSERT/UPDATE baseline.1 parent b936294 commit 02cd0aa
2 files changed
Lines changed: 99 additions & 9 deletions
File tree
- src/billing-cost-management-mcp-server
- awslabs/billing_cost_management_mcp_server/utilities
- tests/utilities
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1606 | 1606 | | |
1607 | 1607 | | |
1608 | 1608 | | |
1609 | | - | |
1610 | | - | |
1611 | | - | |
1612 | | - | |
1613 | | - | |
1614 | | - | |
1615 | | - | |
1616 | 1609 | | |
1617 | 1610 | | |
1618 | 1611 | | |
1619 | 1612 | | |
1620 | | - | |
1621 | | - | |
| 1613 | + | |
| 1614 | + | |
| 1615 | + | |
| 1616 | + | |
| 1617 | + | |
| 1618 | + | |
| 1619 | + | |
| 1620 | + | |
| 1621 | + | |
| 1622 | + | |
| 1623 | + | |
1622 | 1624 | | |
1623 | 1625 | | |
1624 | 1626 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
598 | 598 | | |
599 | 599 | | |
600 | 600 | | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
601 | 689 | | |
602 | 690 | | |
603 | 691 | | |
| |||
0 commit comments