Skip to content

Commit 6fb5969

Browse files
author
Sichan Yoo
committed
Write the new current version to AWSClientRuntime/Resources/sdk-version.txt as well, and use that to initialize user agent middleware during runtime.
1 parent 5b63d6c commit 6fb5969

File tree

5 files changed

+26
-6
lines changed

5 files changed

+26
-6
lines changed

AWSSDKSwiftCLI/Sources/AWSSDKSwiftCLI/Commands/AWSSDKSwiftCLI/Subcommands/PrepareRelease.swift

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,14 @@ struct PrepareRelease {
165165
do {
166166
try "\(newVersion)".write(toFile: "Package.version" , atomically: true, encoding: .utf8)
167167
log("Updated Package.version: \(newVersion)")
168+
if (repoType == .awsSdkSwift) {
169+
try "\(newVersion)".write(
170+
toFile: "Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Resources/sdk-version.txt",
171+
atomically: true,
172+
encoding: .utf8
173+
)
174+
log("Updated AWSClientRuntime/Resources/Package.version: \(newVersion)")
175+
}
168176
} catch {
169177
throw Error("Failed to write version \(newVersion) to Package.version")
170178
}

Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Middlewares/UserAgentMiddleware.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@ public struct UserAgentMiddleware<OperationStackInput, OperationStackOutput> {
2121

2222
public init(
2323
serviceID: String,
24-
version: String,
2524
config: DefaultClientConfiguration & AWSDefaultClientConfiguration
2625
) {
2726
self.serviceID = serviceID
28-
self.version = version
27+
self.version = sdkVersion
2928
self.config = config
3029
}
3130
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
1.0.5
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
//
2+
// Copyright Amazon.com Inc. or its affiliates.
3+
// All Rights Reserved.
4+
//
5+
// SPDX-License-Identifier: Apache-2.0
6+
//
7+
8+
import Foundation
9+
10+
// SDK guarantees sdk-version.txt will be present
11+
let sdkVersionFile = Bundle.module.url(forResource: "sdk-version", withExtension: "txt")!
12+
13+
// First-time load will take longer but subsequent calls will use cached data
14+
// swiftlint:disable:next force_try
15+
public let sdkVersion = try! String(contentsOf: sdkVersionFile, encoding: .utf8)

codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/middleware/UserAgentMiddleware.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ class UserAgentMiddleware(val settings: SwiftSettings) : MiddlewareRenderable {
3434
}
3535

3636
private fun middlewareParamsString(writer: SwiftWriter): String {
37-
return writer.format(
38-
"serviceID: serviceName, version: \$S, config: config",
39-
settings.moduleVersion,
40-
)
37+
return writer.format("serviceID: serviceName, config: config")
4138
}
4239
}

0 commit comments

Comments
 (0)