bind out write data API

Author: sbiscigl

crt/aws-c-http

@@ -10,6 +10,7 @@
 #include <aws/crt/Types.h>
 #include <aws/crt/io/Bootstrap.h>
 #include <aws/crt/io/SocketOptions.h>
+#include <aws/crt/io/Stream.h>
 #include <aws/crt/io/TlsOptions.h>
 
 #include <functional>
@@ -118,6 +119,11 @@ namespace Aws
                  * See `OnStreamComplete` for more info. This value can be empty.
                  */
                 OnStreamComplete onStreamComplete;
+
+                /**
+                 * See `UseManualDataWrites` for more info. If true the write data API must be used to provide data.
+                 */
+                bool UseManualDataWrites = false;
             };
 
             /**
@@ -191,6 +197,8 @@ namespace Aws
                 std::shared_ptr<HttpStream> stream;
             };
 
+            using OnWriteDataComplete = std::function<void(std::shared_ptr<HttpStream> &stream, int errorCode)>;
+
             /**
              * Subclass that represents an http client's view of an HttpStream.
              */
@@ -216,6 +224,11 @@ namespace Aws
                  */
                 bool Activate() noexcept;
 
+                int WriteData(
+                    std::shared_ptr<Aws::Crt::Io::InputStream> stream,
+                    const OnWriteDataComplete &onComplete,
+                    bool endStream = false) noexcept;
+
               private:
                 HttpClientStream(const std::shared_ptr<HttpClientConnection> &connection) noexcept;
 

include/aws/crt/http/HttpConnection.h

@@ -8,6 +8,22 @@
 #include <aws/crt/http/HttpRequestResponse.h>
 #include <aws/crt/io/Bootstrap.h>
 
+namespace
+{
+    struct OnWriteUserData
+    {
+        Aws::Crt::Http::OnWriteDataComplete callback;
+        Aws::Crt::Http::ClientStreamCallbackData callbackData;
+    };
+
+    void s_OnWriteDataComplete(struct aws_http_stream *, int error_code, void *user_data)
+    {
+        auto *userData = static_cast<OnWriteUserData *>(user_data);
+        userData->callback(userData->callbackData.stream, error_code);
+        Aws::Crt::Delete(userData, userData->callbackData.allocator);
+    }
+} // namespace
+
 namespace Aws
 {
     namespace Crt
@@ -202,6 +218,7 @@ namespace Aws
                 options.on_response_headers = HttpStream::s_onIncomingHeaders;
                 options.on_response_header_block_done = HttpStream::s_onIncomingHeaderBlockDone;
                 options.on_complete = HttpStream::s_onStreamComplete;
+                options.use_manual_data_writes = requestOptions.UseManualDataWrites;
 
                 /* Do the same ref counting trick we did with HttpClientConnection. We need to maintain a reference
                  * internally (regardless of what the user does), until the Stream shuts down. */
@@ -361,6 +378,24 @@ namespace Aws
                 return true;
             }
 
+            int HttpClientStream::WriteData(
+                std::shared_ptr<Aws::Crt::Io::InputStream> stream,
+                const OnWriteDataComplete &onComplete,
+                bool endStream) noexcept
+            {
+                aws_http_stream_write_data_options options{};
+                options.data = stream->GetUnderlyingStream();
+                options.end_stream = endStream;
+                options.on_complete = s_OnWriteDataComplete;
+
+                auto *data = Aws::Crt::New<OnWriteUserData>(m_callbackData.allocator);
+                data->callback = onComplete;
+                data->callbackData = m_callbackData;
+                options.user_data = data;
+
+                return aws_http_stream_write_data(m_stream, &options);
+            }
+
             void HttpStream::UpdateWindow(std::size_t incrementSize) noexcept
             {
                 aws_http_stream_update_window(m_stream, incrementSize);