Skip to content

-Wcast-qual not enabled in cmake file #4710

@boquan-fang

Description

@boquan-fang

Problem:

  1. -Wcast-qual is not enabled with awslc.
  2. The S2N_LIBCRYPTO environmental variable needs to be set for that -Wcast-qual to be enabled.

    s2n-tls/CMakeLists.txt

    Lines 212 to 215 in 45bf1d4

    if (NOT $ENV{S2N_LIBCRYPTO} MATCHES "awslc")
    # add cast-qual back in for non AWS-LC
    target_compile_options(${PROJECT_NAME} PRIVATE -Wcast-qual)
    endif()

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • -Wcast-qual should be enabled even if no environmental variables are set.
  • -Wcast-qual should be enabled for awslc.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions