From ad1337bcb77b8c31593a1c6127e986bce3329d7d Mon Sep 17 00:00:00 2001 From: Lindsay Stewart Date: Thu, 6 Mar 2025 12:00:31 -0800 Subject: [PATCH] tests: fix flaky ja4 test --- tests/unit/s2n_fingerprint_ja4_test.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/unit/s2n_fingerprint_ja4_test.c b/tests/unit/s2n_fingerprint_ja4_test.c index df533fc3b13..4603544c907 100644 --- a/tests/unit/s2n_fingerprint_ja4_test.c +++ b/tests/unit/s2n_fingerprint_ja4_test.c @@ -145,9 +145,11 @@ static S2N_RESULT s2n_test_ja4_hash_from_cipher_count(uint16_t cipher_count, }; RESULT_GUARD_POSIX(s2n_stuffer_write_bytes(&bytes, before_ciphers, sizeof(before_ciphers))); - size_t ciphers_size = cipher_count * S2N_TLS_CIPHER_SUITE_LEN; + size_t ciphers_size = cipher_count * sizeof(uint16_t); RESULT_GUARD_POSIX(s2n_stuffer_write_uint16(&bytes, ciphers_size)); - RESULT_GUARD_POSIX(s2n_stuffer_skip_write(&bytes, ciphers_size)); + for (size_t i = 0; i < cipher_count; i++) { + RESULT_GUARD_POSIX(s2n_stuffer_write_uint16(&bytes, 0)); + } uint8_t after_ciphers[] = { S2N_TEST_CLIENT_HELLO_AFTER_CIPHERS,