Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate / downcase extension name during install process #103

Closed
jkatz opened this issue Oct 11, 2022 · 1 comment
Closed

Truncate / downcase extension name during install process #103

jkatz opened this issue Oct 11, 2022 · 1 comment
Assignees
@jkatz
Labels
duplicate This issue or pull request already exists
Milestone
1.0.0

Comments

@jkatz
Copy link
Contributor

jkatz commented Oct 11, 2022

PostgreSQL has this function

extern char *downcase_truncate_identifier(const char *ident, int len, bool warn);

That is used to take identifiers (e.g. extension name) and...downcase and truncate it.

We should call this function on install_extension prior to performing validations.
@jkatz jkatz added the chore label Oct 11, 2022
@jkatz jkatz added this to the 1.0 milestone Oct 11, 2022
@jkatz jkatz mentioned this issue Oct 11, 2022
Open
@jkatz jkatz self-assigned this Oct 11, 2022
@jkatz jkatz closed this as completed Oct 11, 2022
@jkatz jkatz added duplicate This issue or pull request already exists and removed chore labels Oct 11, 2022
@jkatz
Copy link
Contributor Author

jkatz commented Oct 11, 2022

Basically a duplicate of #100 and the nuances in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkatz jkatz

Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@jkatz