Skip to content

Commit e90de56

Browse files
committed
Revert "Merge branch 'master' of github.com:aws/aws-sdk-java-v2 into createAnonymousCredentials"
This reverts commit 7dc8409, reversing changes made to 3524907.
1 parent 7dc8409 commit e90de56

File tree

7 files changed

+4
-42
lines changed

7 files changed

+4
-42
lines changed

.changes/next-release/bugfix-AWSS3-54f8f8c.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changes/next-release/feature-AWSSDKforJavav2-6d1b1b5.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

AWSCLIV2.pkg

-28.2 MB
Binary file not shown.

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
<rxjava.version>2.2.21</rxjava.version>
114114
<commons-codec.verion>1.10</commons-codec.verion>
115115
<jmh.version>1.29</jmh.version>
116-
<awscrt.version>0.19.2</awscrt.version>
116+
<awscrt.version>0.19.0</awscrt.version>
117117

118118
<!--Test dependencies -->
119119
<junit5.version>5.8.1</junit5.version>

services/s3/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,5 @@
143143
<artifactId>eventstream</artifactId>
144144
<scope>test</scope>
145145
</dependency>
146-
147146
</dependencies>
148147
</project>

services/s3/src/main/java/software/amazon/awssdk/services/s3/internal/crt/CrtCredentialsProviderAdapter.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import java.nio.charset.StandardCharsets;
2020
import software.amazon.awssdk.annotations.SdkInternalApi;
21-
import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
2221
import software.amazon.awssdk.auth.credentials.AwsCredentials;
2322
import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
2423
import software.amazon.awssdk.auth.credentials.AwsSessionCredentials;
@@ -39,11 +38,6 @@ public CrtCredentialsProviderAdapter(AwsCredentialsProvider credentialsProvider)
3938
this.credentialsProvider = credentialsProvider;
4039
this.crtCredentials = new DelegateCredentialsProvider.DelegateCredentialsProviderBuilder()
4140
.withHandler(() -> {
42-
43-
if (credentialsProvider instanceof AnonymousCredentialsProvider) {
44-
return Credentials.createAnonymousCredentials();
45-
}
46-
4741
AwsCredentials sdkCredentials = credentialsProvider.resolveCredentials();
4842
byte[] accessKey = sdkCredentials.accessKeyId().getBytes(StandardCharsets.UTF_8);
4943
byte[] secreteKey = sdkCredentials.secretAccessKey().getBytes(StandardCharsets.UTF_8);
@@ -53,10 +47,10 @@ public CrtCredentialsProviderAdapter(AwsCredentialsProvider credentialsProvider)
5347
sessionTokens =
5448
((AwsSessionCredentials) sdkCredentials).sessionToken().getBytes(StandardCharsets.UTF_8);
5549
}
56-
return new Credentials(accessKey,
57-
secreteKey,
58-
sessionTokens);
5950

51+
return new Credentials(accessKey,
52+
secreteKey,
53+
sessionTokens);
6054
}).build();
6155
}
6256

services/s3/src/test/java/software/amazon/awssdk/services/s3/internal/crt/CrtCredentialProviderAdapterTest.java

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import java.nio.charset.StandardCharsets;
2323
import org.junit.jupiter.api.Test;
2424
import org.mockito.Mockito;
25-
import software.amazon.awssdk.auth.credentials.AnonymousCredentialsProvider;
2625
import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
2726
import software.amazon.awssdk.auth.credentials.AwsCredentials;
2827
import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider;
@@ -92,21 +91,4 @@ public String secretAccessKey() {
9291
adapter.close();
9392
verify((SdkAutoCloseable) awsCredentialsProvider).close();
9493
}
95-
96-
@Test
97-
public void crtCredentials_anonymousCredentialsProvider_shouldWork() {
98-
AwsCredentialsProvider awsCredentialsProvider = AnonymousCredentialsProvider.create();
99-
100-
CrtCredentialsProviderAdapter adapter = new CrtCredentialsProviderAdapter(awsCredentialsProvider);
101-
CredentialsProvider crtCredentialsProvider = adapter.crtCredentials();
102-
103-
Credentials crtCredentials = crtCredentialsProvider.getCredentials().join();
104-
105-
assertThat(crtCredentials.getAccessKeyId()).isNull();
106-
assertThat(crtCredentials.getSecretAccessKey()).isNull();
107-
108-
}
109-
110-
111-
11294
}

0 commit comments

Comments
 (0)