Skip to content

Plans to aws-lc-fips-sys 0.12.11 release #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samin-cf opened this issue Jul 26, 2024 · 3 comments
Closed

Plans to aws-lc-fips-sys 0.12.11 release #466

samin-cf opened this issue Jul 26, 2024 · 3 comments
Assignees

Comments

@samin-cf
Copy link

samin-cf commented Jul 26, 2024

On some Windows machines (specifically Windows-2022 Azure pipeline image), aws-lc-fips-sys fails to compile because the output of vcvarsall.bat isn't fully captured. I have narrowed down the issue to https://github.com/aws/aws-lc-rs/blob/aws-lc-fips-sys/v0.12.10/aws-lc-fips-sys/builder/main.rs#L147.

If I build against my own fork with increased output limit, there are no issues. Seems like @justsmth ran into this as well and updated the max command output limit as part of #452.

Would it be possible to do a v0.12.11 release anytime soon that includes @justsmth's changes?

@justsmth
Copy link
Contributor

I've got a PR up for it now. The release should be very soon.

@justsmth justsmth self-assigned this Jul 29, 2024
@justsmth
Copy link
Contributor

New version of aws-lc-fips-sys released: https://crates.io/crates/aws-lc-fips-sys/0.12.11

:-)

@samin-cf
Copy link
Author

Awesome, thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants