Build not working if missing a git config

[afalzonelab]

Hi,
building prometheus-slurm-exporter binary I found this error at head node post-install:

 cd /home/ec2-user/aws-parallelcluster-monitoring/prometheus-slurm-exporter; git status --porcelain
fatal: detected dubious ownership in repository at '/home/ec2-user/aws-parallelcluster-monitoring/prometheus-slurm-exporter'
To add an exception for this directory, call:

        git config --global --add safe.directory /home/ec2-user/aws-parallelcluster-monitoring/prometheus-slurm-exporter
error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.
make: *** [bin/prometheus-slurm-exporter] Error 1

Testing manually, I solved with the fix following:

--- install-monitoring.sh.orig  2024-03-28 11:51:28.513604048 +0000
+++ install-monitoring.sh       2024-03-28 11:39:43.415747930 +0000
@@ -89,6 +89,7 @@
                # More info here: https://github.com/vpenso/prometheus-slurm-exporter/blob/master/LICENSE
                cd ${monitoring_home}
                git clone https://github.com/vpenso/prometheus-slurm-exporter.git
+                git config --global --add safe.directory ${monitoring_home}/prometheus-slurm-exporter
                sed -i 's/NodeList,AllocMem,Memory,CPUsState,StateLong/NodeList: ,AllocMem: ,Memory: ,CPUsState: ,StateLong:/' prometheus-slurm-exporter/node.go
                cd prometheus-slurm-exporter
                GOPATH=/root/go-modules-cache HOME=/root go mod download

Please, could you fix the on repo?

Thanks,
Alberto

[nicolaven]

Hi @afalzonelab , can you please send a pull request?
Thanks

[zhaohaom-aws]

Hi, I am seeing the same issue when installing in AL2. Could you release the fix with a newer version?

[spicysomtam]

Just experienced this issue on the head node; its something to do with the go build. A couple of work arounds:

GOPATH=/root/go-modules-cache HOME=/root go build -buildvcs=false

Or:

GOFLAGS=-buildvcs=false GOPATH=/root/go-modules-cache HOME=/root go build

Quite an easy fix if someone can look at this, otherwise the go build fails and the slurm_exporter is not setup. UPDATE: This happens on Amazon Linux 2023 as well:

+ cd prometheus-slurm-exporter
+ GOPATH=/root/go-modules-cache
+ HOME=/root
+ go mod download
+ GOPATH=/root/go-modules-cache
+ HOME=/root
+ go build
error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.
+ mv /home/ec2-user/aws-parallelcluster-monitoring/prometheus-slurm-exporter/prometheus-slurm-exporter /usr/bin/prometheus-slurm-exporter
mv: cannot stat ‘/home/ec2-user/aws-parallelcluster-monitoring/prometheus-slurm-exporter/prometheus-slurm-exporter’: No such file or directory
+ systemctl daemon-reload
+ systemctl enable slurm_exporter
Created symlink from /etc/systemd/system/multi-user.target.wants/slurm_exporter.service to /etc/systemd/system/slurm_exporter.service.
+ systemctl start slurm_exporter

Useful Stackoverflow link.