Fix/update table gsi (#87)

joaquinservetto · web-flow · commit 78ec5b0255a8 · 2023-11-23T04:10:23.000Z
Issue #, if available: aws-controllers-k8s/community#1920 Description of changes: Fix error faced when creating a gsi for an existing table using already defined attributes. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/pkg/resource/table/hooks.go b/pkg/resource/table/hooks.go
@@ -223,7 +223,7 @@ func (rm *resourceManager) customUpdateTable(
 			if err := rm.syncTableProvisionedThroughput(ctx, desired); err != nil {
 				return nil, err
 			}
-		case delta.DifferentAt("Spec.GlobalSecondaryIndexes") && delta.DifferentAt("Spec.AttributeDefinitions"):
+		case delta.DifferentAt("Spec.GlobalSecondaryIndexes"):
 			if err := rm.syncTableGlobalSecondaryIndexes(ctx, latest, desired); err != nil {
 				if awsErr, ok := ackerr.AWSError(err); ok &&
 					awsErr.Code() == "LimitExceededException" {

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ func (rm *resourceManager) customUpdateTable(`
`223`	`223`	`if err := rm.syncTableProvisionedThroughput(ctx, desired); err != nil {`
`224`	`224`	`return nil, err`
`225`	`225`	`}`
`226`		`- case delta.DifferentAt("Spec.GlobalSecondaryIndexes") && delta.DifferentAt("Spec.AttributeDefinitions"):`
	`226`	`+ case delta.DifferentAt("Spec.GlobalSecondaryIndexes"):`
`227`	`227`	`if err := rm.syncTableGlobalSecondaryIndexes(ctx, latest, desired); err != nil {`
`228`	`228`	`if awsErr, ok := ackerr.AWSError(err); ok &&`
`229`	`229`	`awsErr.Code() == "LimitExceededException" {`