Skip to content

Commit e3bc6b5

Browse files
authored
Merge pull request #184 from scottschreckengaust/node24
fix(upgrade): upate node version from 20 to 24
2 parents d8279f3 + e7345b5 commit e3bc6b5

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ The only required input is `project-name`.
7979
1. **source-type-override** (optional) :
8080
The source type that overrides the `sourceTypeOverride` provided to Codebuild.
8181
1. **source-location-override** (optional) :
82-
The source location that overrides the `sourceLocationOverride` provided to Codebuild.
82+
The source location that overrides the `sourceLocationOverride` provided to Codebuild.
8383
1. **env-vars-for-codebuild** (optional) :
8484
A comma-separated list of the names of environment variables
8585
that the action passes from GitHub Actions to CodeBuild.
@@ -289,6 +289,7 @@ npx github:aws-actions/aws-codebuild-run-build -p ProjectName -r remoteName
289289
```
290290
291291
Note: If the above command returns a 404 error, you might need to add the package manually.
292+
292293
```
293294
npm install git@github.com:aws-actions/aws-codebuild-run-build.git
294295
# OR

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ outputs:
6060
aws-build-id:
6161
description: 'The AWS CodeBuild Build ID for this build.'
6262
runs:
63-
using: 'node20'
63+
using: 'node24'
6464
main: 'dist/index.js'

code-build.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,15 @@ function githubInputs() {
199199
// the GITHUB_SHA value is NOT the correct value.
200200
// See: https://github.com/aws-actions/aws-codebuild-run-build/issues/36
201201
const sourceVersion =
202-
core.getInput("source-version-override", { required: false }) ||
202+
core.getInput("source-version-override", { required: false }) ||
203203
(process.env[`GITHUB_EVENT_NAME`] === "pull_request"
204204
? (((payload || {}).pull_request || {}).head || {}).sha
205205
: process.env[`GITHUB_SHA`]);
206206

207207
assert(sourceVersion, "No source version could be evaluated.");
208208

209-
const sourceTypeOverride =
210-
core.getInput("source-type-override", { required: false, }) || undefined;
209+
const sourceTypeOverride =
210+
core.getInput("source-type-override", { required: false }) || undefined;
211211

212212
const sourceLocationOverride =
213213
core.getInput("source-location-override", { required: false }) || undefined;
@@ -309,9 +309,10 @@ function inputs2Parameters(inputs) {
309309
// sourceVersion should not be set when using sourceTypeOverride or sourceLocationOverride
310310
...(sourceTypeOverride || sourceLocationOverride
311311
? {}
312-
: {sourceVersion}),
312+
: { sourceVersion }),
313313
sourceTypeOverride: sourceTypeOverride || "GITHUB",
314-
sourceLocationOverride: sourceLocationOverride || `https://github.com/${owner}/${repo}.git`,
314+
sourceLocationOverride:
315+
sourceLocationOverride || `https://github.com/${owner}/${repo}.git`,
315316
}
316317
: {};
317318

test/code-build-test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,9 @@ describe("inputs2Parameters", () => {
430430
sourceLocationOverride: "bucket-name/object-name",
431431
});
432432
expect(test).to.haveOwnProperty("sourceTypeOverride").and.to.equal("S3");
433-
expect(test).to.haveOwnProperty("sourceLocationOverride").and.to.equal("bucket-name/object-name");
433+
expect(test)
434+
.to.haveOwnProperty("sourceLocationOverride")
435+
.and.to.equal("bucket-name/object-name");
434436
expect(test).to.not.haveOwnProperty("sourceVersion");
435437
});
436438

0 commit comments

Comments
 (0)