Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen replaces underscores by spaces #23

Open
2 tasks done
danielo515 opened this issue Mar 3, 2024 · 0 comments · May be fixed by #24
Open
2 tasks done

codegen replaces underscores by spaces #23

danielo515 opened this issue Mar 3, 2024 · 0 comments · May be fixed by #24

Comments

@danielo515
Copy link

Describe the bug

Hello, thank you for this utility, it makes dealing with kysely migrations much more convenient.
I tried the codegen function, and while it worked quite good, the generated names get underscore replaced by spaces, which is incorrect.

To give you an example user_session generates a type named User Session which is obviously not valid typescript.

Link to Minimal Reproducible Example

I don't think is needed, sorry

Steps To Reproduce

Just use any underscore in any table name then try to run a codegen command

Package Version

kysely-migrate 0.0.16

TypeScript Version

5.3.3

Anything else?

No response

Validations

  • Checked there isn't already an issue that exists for the bug you encountered.
  • Added a minimal reproduction.
danielo515 added a commit to danielo515/kysely-migrate that referenced this issue Mar 3, 2024
@danielo515 danielo515 linked a pull request Mar 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant